Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 8618001: Get rid of the EnableClose() infrastructure in Widget. (Closed)

Created:
9 years, 1 month ago by Ben Goodger (Google)
Modified:
9 years, 1 month ago
Reviewers:
Miranda Callahan, sky
CC:
chromium-reviews, msw+watch_chromium.org, nkostylev+watch_chromium.org, tfarina, Dmitry Titov, dcheng, prasadt, jennb, jianli, alicet1, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, dhollowa
Visibility:
Public.

Description

Get rid of the EnableClose() infrastructure in Widget. Only one place was left using it (FirstRunSearchEngineView), and Brian said that didn't need to use it if it would just pick the first of the engine choices (prior to randomization) as the window was closed. http://crbug.com/102581 TEST=unittests, and: run organic first run chrome, close the search engine selector, the Google should be the default. run organic first run Chrome, choose a non-Google engine, it should be the default. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111096

Patch Set 1 : '' #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -118 lines) Patch
M chrome/browser/chromeos/frame/bubble_frame_view.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/frame/bubble_frame_view.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_frame_view.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browser_frame_view.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_views.cc View 1 2 3 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/first_run_search_engine_view.h View 1 2 3 4 chunks +26 lines, -1 line 0 comments Download
M chrome/browser/ui/views/first_run_search_engine_view.cc View 1 2 3 8 chunks +37 lines, -23 lines 0 comments Download
A chrome/browser/ui/views/first_run_search_engine_view_unittest.cc View 1 2 1 chunk +51 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/app_panel_browser_frame_view.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/app_panel_browser_frame_view.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/frame/popup_non_client_frame_view.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/popup_non_client_frame_view.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/test/base/testing_profile.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
M ui/aura_shell/toplevel_frame_view.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura_shell/toplevel_frame_view.cc View 1 2 3 2 chunks +0 lines, -9 lines 0 comments Download
M ui/views/bubble/bubble_frame_view.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M ui/views/widget/native_widget_gtk.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/native_widget_gtk.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/widget/native_widget_private.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/native_widget_win.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/native_widget_win.cc View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M ui/views/widget/widget.h View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/widget/widget.cc View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M ui/views/window/custom_frame_view.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/window/custom_frame_view.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/window/native_frame_view.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/window/native_frame_view.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/window/non_client_view.h View 1 2 3 2 chunks +0 lines, -5 lines 0 comments Download
M ui/views/window/non_client_view.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
mirandac: first_run_search_view.cc/h, _unittest.cc sky: everything else (testing profile, views api changes)
9 years, 1 month ago (2011-11-22 00:01:07 UTC) #1
Miranda Callahan
On 2011/11/22 00:01:07, Ben Goodger (Google) wrote: > mirandac: first_run_search_view.cc/h, _unittest.cc > sky: everything else ...
9 years, 1 month ago (2011-11-22 00:11:58 UTC) #2
sky
9 years, 1 month ago (2011-11-22 00:37:32 UTC) #3
LGTM

http://codereview.chromium.org/8618001/diff/10004/chrome/browser/ui/views/fir...
File chrome/browser/ui/views/first_run_search_engine_view_unittest.cc (right):

http://codereview.chromium.org/8618001/diff/10004/chrome/browser/ui/views/fir...
chrome/browser/ui/views/first_run_search_engine_view_unittest.cc:8: #include
"chrome/browser/ui/views/first_run_search_engine_view.h"
nit: include this first (just like for first_run_search_engine_view.cc).

http://codereview.chromium.org/8618001/diff/10004/chrome/browser/ui/views/fir...
chrome/browser/ui/views/first_run_search_engine_view_unittest.cc:25: // Set a
dummy provider as the default so we can verify something changed.
Should you have:
EXPECT_NE(d3, service->GetDefaultSearchProvider())
at the end?

http://codereview.chromium.org/8618001/diff/10004/chrome/browser/ui/views/fir...
chrome/browser/ui/views/first_run_search_engine_view_unittest.cc:28:
TemplateURL* d1 = new TemplateURL;
ASSERT_TRUE(service != NULL);

http://codereview.chromium.org/8618001/diff/10004/chrome/browser/ui/views/fir...
chrome/browser/ui/views/first_run_search_engine_view_unittest.cc:45:
service->GetTemplateURLs();
ASSERT_TRUE(!template_urls.empty())

Powered by Google App Engine
This is Rietveld 408576698