Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 8616008: Remove IsProtocolSupportedForMedia (Closed)

Created:
9 years, 1 month ago by piman
Modified:
9 years, 1 month ago
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, jam, annacc+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, vrk (LEFT CHROMIUM), pam+watch_chromium.org, scherkus (not reviewing), ihf+watch_chromium.org
Visibility:
Public.

Description

Remove IsProtocolSupportedForMedia. scherkus says: The protocol whitelist (added in r26746) was originally required to prevent issuing requests to the resource loader bridge that it didn't support (i.e., data://). To complicate matters there were protocols such as chrome-extension:// that required the embedder to override. None of this is required anymore since we switched to using Chromium WebKit API's resource loader in r69429. BUG=98755 TEST=Chrome, DRT, test_shell, test_shell_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111075

Patch Set 1 #

Total comments: 4

Patch Set 2 : review fixes #

Patch Set 3 : fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -72 lines) Patch
M chrome/renderer/chrome_content_renderer_client.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M content/public/renderer/content_renderer_client.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/mock_content_renderer_client.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/mock_content_renderer_client.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/renderer_glue.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M content/shell/shell_content_renderer_client.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/shell_content_renderer_client.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/glue/webkit_glue.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/media/buffered_data_source.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M webkit/media/buffered_resource_loader.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M webkit/media/simple_data_source.cc View 2 chunks +1 line, -2 lines 0 comments Download
M webkit/support/webkit_support_glue.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
piman
scherkus: please review tony: OWNERS
9 years, 1 month ago (2011-11-21 21:52:01 UTC) #1
Dirk Pranke
why is it okay to remove this? (I'm curious as to what the discussion was ...
9 years, 1 month ago (2011-11-21 21:57:46 UTC) #2
piman
+darin for webkit/ OWNERS since tony looks like he's out.
9 years, 1 month ago (2011-11-21 22:26:24 UTC) #3
scherkus (not reviewing)
dpranke: added my explanation in CL description LGTM but I think there are more things ...
9 years, 1 month ago (2011-11-21 22:26:41 UTC) #4
darin (slow to review)
LGTM
9 years, 1 month ago (2011-11-21 22:41:07 UTC) #5
piman
+jam for content/public OWNER http://codereview.chromium.org/8616008/diff/1/content/renderer/renderer_glue.cc File content/renderer/renderer_glue.cc (left): http://codereview.chromium.org/8616008/diff/1/content/renderer/renderer_glue.cc#oldcode170 content/renderer/renderer_glue.cc:170: content::GetContentClient()->renderer()->IsProtocolSupportedForMedia(url); On 2011/11/21 22:26:41, scherkus ...
9 years, 1 month ago (2011-11-21 23:13:02 UTC) #6
jam
lgtm
9 years, 1 month ago (2011-11-21 23:56:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/8616008/1018
9 years, 1 month ago (2011-11-22 00:04:35 UTC) #8
commit-bot: I haz the power
9 years, 1 month ago (2011-11-22 02:04:25 UTC) #9
Change committed as 111075

Powered by Google App Engine
This is Rietveld 408576698