Implement meta referrer (part 1/2)

Implement meta referrer (part 1/2)

Store the referrer policy in the web url loader and use it during redirects

BUG=10502
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111457

[jochen (gone - plz use gerrit), 2011-11-21 21:12:32]

Darin, could you please review this?

[darin (slow to review), 2011-11-21 22:44:37]

http://codereview.chromium.org/8616006/diff/7001/webkit/glue/weburlloader_imp...
File webkit/glue/weburlloader_impl.cc (right):

http://codereview.chromium.org/8616006/diff/7001/webkit/glue/weburlloader_imp...
webkit/glue/weburlloader_impl.cc:421: referrer_policy_ =
static_cast<WebURLRequestExtraDataImpl*>(
should you null check request.extraData() here?  outside the context of
RenderViewImpl, it seems like WebURLLoaderImpl could be used in contexts where
setExtraData has not been called.  maybe that explains some of the try bot test
failures?

[jochen (gone - plz use gerrit), 2011-11-22 10:38:28]

http://codereview.chromium.org/8616006/diff/7001/webkit/glue/weburlloader_imp...
File webkit/glue/weburlloader_impl.cc (right):

http://codereview.chromium.org/8616006/diff/7001/webkit/glue/weburlloader_imp...
webkit/glue/weburlloader_impl.cc:421: referrer_policy_ =
static_cast<WebURLRequestExtraDataImpl*>(
I've added both the null check, and code to the test shell to set the extra data

[darin (slow to review), 2011-11-23 16:57:06]

LGTM

[commit-bot: I haz the power, 2011-11-23 17:22:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/8616006/12001

[commit-bot: I haz the power, 2011-11-23 17:22:18]

Can't apply patch for file webkit/glue/weburlloader_impl.cc.
While running patch -p1 --forward --force;
patching file webkit/glue/weburlloader_impl.cc
Hunk #1 FAILED at 31.
Hunk #2 succeeded at 40 (offset 2 lines).
Hunk #3 succeeded at 296 (offset 3 lines).
Hunk #4 succeeded at 305 (offset 3 lines).
Hunk #5 succeeded at 421 with fuzz 2 (offset 4 lines).
Hunk #6 succeeded at 500 (offset 4 lines).
1 out of 6 hunks FAILED -- saving rejects to file
webkit/glue/weburlloader_impl.cc.rej

[commit-bot: I haz the power, 2011-11-23 20:49:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/8616006/19001

[commit-bot: I haz the power, 2011-11-23 21:58:00]

Try job failure for 8616006-19001 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2011-11-23 23:02:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/8616006/19001

[commit-bot: I haz the power, 2011-11-24 00:58:10]

Change committed as 111457