Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8614003: Add OVERRIDE to chrome/browser/. (Closed)

Created:
9 years, 1 month ago by Avi (use Gerrit)
Modified:
9 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews, creis+watch_chromium.org, achuith+watch_chromium.org, Erik does not do reviews, ajwong+watch_chromium.org, jam, mihaip+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, rginda+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, yoshiki+watch_chromium.org, brettw-cc_chromium.org, stuartmorgan+watch_chromium.org, dhollowa
Visibility:
Public.

Description

Add OVERRIDE to chrome/browser/. BUG=104314 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110940

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+400 lines, -353 lines) Patch
M chrome/browser/omnibox_search_hint.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/parsers/metadata_parser_filebase.h View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/parsers/metadata_parser_jpeg.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/parsers/metadata_parser_jpeg_factory.h View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/password_manager_delegate_impl.h View 3 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/plugin_data_remover_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/asynchronous_policy_test_base.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/configuration_policy_provider_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/device_management_backend_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/preferences_mock_mac.h View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/prefs/overlay_user_pref_store.h View 2 chunks +18 lines, -17 lines 0 comments Download
M chrome/browser/prefs/pref_member.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/pref_notifier_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/pref_set_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/pref_value_store.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/testing_pref_store.h View 1 chunk +16 lines, -15 lines 0 comments Download
M chrome/browser/prefs/value_map_pref_store.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_flow.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_source.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud_internal.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_job_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_preview_tab_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/printing_message_filter.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_io_data.h View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.h View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/repost_form_warning_controller.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database.h View 1 chunk +17 lines, -14 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store_file.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/search_provider_install_data.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/search_provider_install_state_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/search_terms_data.h View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/search_engines/template_url_service.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_factory.h View 1 chunk +7 lines, -6 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/service/service_process_control.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sessions/session_service.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sessions/session_service_factory.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/tab_restore_service_factory.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/shell_integration.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sidebar/sidebar_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/speech/speech_input_bubble.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/speech/speech_input_bubble_controller.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_host_impl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/tab_contents/background_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/chrome_interstitial_page.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/insecure_content_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_mac.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_mac.h View 1 chunk +14 lines, -12 lines 0 comments Download
M chrome/browser/tab_contents/thumbnail_generator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/tabs/default_tab_handler.h View 1 chunk +30 lines, -27 lines 0 comments Download
M chrome/browser/tabs/pinned_tab_service.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/tabs/tab_strip_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tabs/tab_strip_model_order_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.h View 8 chunks +30 lines, -30 lines 0 comments Download
M chrome/browser/task_manager/task_manager_worker_resource_provider.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/themes/theme_service.h View 2 chunks +16 lines, -15 lines 0 comments Download
M chrome/browser/themes/theme_service_factory.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/translate/languages_menu_model.h View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/translate/options_menu_model.h View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/translate/translate_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/transport_security_persister.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/blocked_content/blocked_content_container.h View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser.h View 4 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/login/login_prompt.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/search_engines/template_url_table_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model.h View 1 chunk +18 lines, -16 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_dialog.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/user_style_sheet_watcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/visitedlink/visitedlink_event_listener.h View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/web_resource/gpu_blacklist_updater.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/autofill_table.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/webdata/keyword_table.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/webdata/logins_table.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/webdata/token_service_table.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/webdata/web_apps_table.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/webdata/web_intents_table.h View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Avi (use Gerrit)
9 years, 1 month ago (2011-11-21 15:28:46 UTC) #1
Nico
lgtm thanks for breaking chrome/browser up into multiple cls :-)
9 years, 1 month ago (2011-11-21 16:18:41 UTC) #2
Avi (use Gerrit)
9 years, 1 month ago (2011-11-21 16:27:39 UTC) #3 
On 2011/11/21 16:18:41, Nico wrote:
> lgtm
> 
> thanks for breaking chrome/browser up into multiple cls :-)

It didn't upload as one CL; too long of an auto-generated CC line :)

Powered by Google App Engine
This is Rietveld 408576698