Issue 8613001: Revert 110905 - Adding parameter to GetStatusLabels to indicate if links are acceptable, as some ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8613001: Revert 110905 - Adding parameter to GetStatusLabels to indicate if links are acceptable, as some ... (Closed)

Created:
9 years, 1 month ago by Torne

Modified:
9 years, 1 month ago

Reviewers:
jimblackler

CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing), Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 110905 - Adding parameter to GetStatusLabels to indicate if links are acceptable, as some platforms cannot handle links in all the places these messages are shown. Also adding unit tests for other functionality of GetStatusLabels. BUG=none, discussed beforehand with akalin TEST=HtmlNotIncludedInStatusIfNotRequested Review URL: http://codereview.chromium.org/8383036 TBR=jimblackler@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110909

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -258 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.h	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View	2 chunks	+0 lines, -8 lines	0 comments	Download
	chrome/browser/sync/profile_sync_service_mock.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/sync_global_error_unittest.cc	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/sync_ui_util.h	View	1 chunk	+1 line, -7 lines	0 comments	Download
M	chrome/browser/sync/sync_ui_util.cc	View	6 chunks	+10 lines, -24 lines	0 comments	Download
M	chrome/browser/sync/sync_ui_util_unittest.cc	View	6 chunks	+3 lines, -204 lines	0 comments	Download
M	chrome/browser/ui/webui/options/personal_options_handler.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

lgtm