Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 8610006: Upstream: Gyp changes to build net_unittests for Android. (Closed)

Created:
9 years, 1 month ago by Jing Zhao
Modified:
9 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, brettw-cc_chromium.org, michaelbai, John Grabowski
Visibility:
Public.

Description

Upstream: Gyp changes to build net_unittests for Android. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111114

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -25 lines) Patch
M base/base.gypi View 3 chunks +15 lines, -8 lines 0 comments Download
A build/android/system.gyp View 1 chunk +24 lines, -0 lines 0 comments Download
M build/common.gypi View 2 chunks +9 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jing Zhao
Hi Mark, Could you help to review this change? Thanks, Jing
9 years, 1 month ago (2011-11-21 16:49:16 UTC) #1
Mark Mentovai
LGTM
9 years, 1 month ago (2011-11-21 16:51:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jingzhao@chromium.org/8610006/1
9 years, 1 month ago (2011-11-22 06:46:06 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-22 07:53:02 UTC) #4
Change committed as 111114

Powered by Google App Engine
This is Rietveld 408576698