Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Unified Diff: chrome/browser/browser_process_impl.cc

Issue 8609010: Make DevToolsManager a singleton, remove it from ContentBrowserClient (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reverted notification service changes, use non-leaky singleton Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_process_impl.h ('k') | chrome/browser/chrome_content_browser_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_process_impl.cc
diff --git a/chrome/browser/browser_process_impl.cc b/chrome/browser/browser_process_impl.cc
index 77e2d90d02b79c3ceea32d58ce937a3573e08078..9d34c3b692246152711b9c17155e60c74072f6a1 100644
--- a/chrome/browser/browser_process_impl.cc
+++ b/chrome/browser/browser_process_impl.cc
@@ -71,7 +71,6 @@
#include "chrome/installer/util/google_update_constants.h"
#include "content/browser/browser_process_sub_thread.h"
#include "content/browser/child_process_security_policy.h"
-#include "content/browser/debugger/devtools_manager.h"
#include "content/browser/download/download_file_manager.h"
#include "content/browser/download/download_status_updater.h"
#include "content/browser/download/mhtml_generation_manager.h"
@@ -138,7 +137,6 @@ BrowserProcessImpl::BrowserProcessImpl(const CommandLine& command_line)
created_profile_manager_(false),
created_local_state_(false),
created_icon_manager_(false),
- created_devtools_manager_(false),
created_sidebar_manager_(false),
created_browser_policy_connector_(false),
created_notification_ui_manager_(false),
@@ -466,13 +464,6 @@ PrefService* BrowserProcessImpl::local_state() {
return local_state_.get();
}
-DevToolsManager* BrowserProcessImpl::devtools_manager() {
- DCHECK(CalledOnValidThread());
- if (!created_devtools_manager_)
- CreateDevToolsManager();
- return devtools_manager_.get();
-}
-
SidebarManager* BrowserProcessImpl::sidebar_manager() {
DCHECK(CalledOnValidThread());
if (!created_sidebar_manager_)
@@ -956,12 +947,6 @@ void BrowserProcessImpl::CreateIconManager() {
icon_manager_.reset(new IconManager);
}
-void BrowserProcessImpl::CreateDevToolsManager() {
- DCHECK(devtools_manager_.get() == NULL);
- created_devtools_manager_ = true;
- devtools_manager_.reset(new DevToolsManager());
-}
-
void BrowserProcessImpl::CreateSidebarManager() {
DCHECK(sidebar_manager_.get() == NULL);
created_sidebar_manager_ = true;
« no previous file with comments | « chrome/browser/browser_process_impl.h ('k') | chrome/browser/chrome_content_browser_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698