Linux/Gtk: Drag source should not delete source data on drop in tab strip.

Linux/Gtk: Drag source should not delete source data on drop in tab strip.

BUG=104949
.
TEST=As described in the bug.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111316

[SanjoyPal, 2011-11-21 09:15:16]

PTAL.

[James Hawkins, 2011-11-21 17:33:59]

http://codereview.chromium.org/8609009/diff/1/chrome/browser/ui/gtk/tabs/tab_...
File chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc (right):

http://codereview.chromium.org/8609009/diff/1/chrome/browser/ui/gtk/tabs/tab_...
chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc:2137: bool success = false;
|success| is not unused.

[James Hawkins, 2011-11-21 17:35:01]

On 2011/11/21 17:33:59, James Hawkins wrote:
>
http://codereview.chromium.org/8609009/diff/1/chrome/browser/ui/gtk/tabs/tab_...
> File chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc (right):
> 
>
http://codereview.chromium.org/8609009/diff/1/chrome/browser/ui/gtk/tabs/tab_...
> chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc:2137: bool success = false;
> |success| is not unused.

s/not/now/

[SanjoyPal, 2011-11-22 07:21:17]

On 2011/11/21 17:35:01, James Hawkins wrote:
> On 2011/11/21 17:33:59, James Hawkins wrote:
> >
>
http://codereview.chromium.org/8609009/diff/1/chrome/browser/ui/gtk/tabs/tab_...
> > File chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc (right):
> > 
> >
>
http://codereview.chromium.org/8609009/diff/1/chrome/browser/ui/gtk/tabs/tab_...
> > chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc:2137: bool success = false;
> > |success| is not unused.
> 
> s/not/now/

"|success| is now unused"

I din't get this comments.

|success| is used to indicate whether the drop was successful in
gtk_drag_finish(context, success, FALSE, time);

and the third argument in gtk_drag_finish is used to indicate whether the source
should delete the original data. (This should be TRUE for a move). Now, because
we setting it success, the source data is being deleted when success is TRUE.

[James Hawkins, 2011-11-22 17:12:09]

On 2011/11/22 07:21:17, SanjoyPal wrote:
> On 2011/11/21 17:35:01, James Hawkins wrote:
> > On 2011/11/21 17:33:59, James Hawkins wrote:
> > >
> >
>
http://codereview.chromium.org/8609009/diff/1/chrome/browser/ui/gtk/tabs/tab_...
> > > File chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc (right):
> > > 
> > >
> >
>
http://codereview.chromium.org/8609009/diff/1/chrome/browser/ui/gtk/tabs/tab_...
> > > chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc:2137: bool success = false;
> > > |success| is not unused.
> > 
> > s/not/now/
> 
> "|success| is now unused"
> 
> I din't get this comments.
> 
> |success| is used to indicate whether the drop was successful in
> gtk_drag_finish(context, success, FALSE, time);
> 
> and the third argument in gtk_drag_finish is used to indicate whether the
source
> should delete the original data. (This should be TRUE for a move). Now,
because
> we setting it success, the source data is being deleted when success is TRUE.

My apologies, I missed that one in the diff.

[James Hawkins, 2011-11-22 17:13:26]

lgtm

[commit-bot: I haz the power, 2011-11-22 17:13:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ncj674@motorola.com/8609009/1

[commit-bot: I haz the power, 2011-11-22 18:47:16]

Try job failure for 8609009-1 (retry) on mac_rel for step "ui_tests" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2011-11-23 02:39:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ncj674@motorola.com/8609009/1

[commit-bot: I haz the power, 2011-11-23 04:34:32]

Change committed as 111316