Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Side by Side Diff: net/http/http_proxy_utils.cc

Issue 8609006: Revert 110879 - Allow chrome to handle 407 auth challenges to CONNECT requests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/http/http_proxy_utils.h ('k') | net/http/http_stream_factory_impl_job.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/http/http_proxy_utils.h" 5 #include "net/http/http_proxy_utils.h"
6 6
7 #include "base/logging.h"
8 #include "base/stringprintf.h" 7 #include "base/stringprintf.h"
9 #include "googleurl/src/gurl.h" 8 #include "googleurl/src/gurl.h"
10 #include "net/base/host_port_pair.h" 9 #include "net/base/host_port_pair.h"
11 #include "net/base/net_errors.h"
12 #include "net/base/net_util.h" 10 #include "net/base/net_util.h"
13 #include "net/http/http_auth_controller.h"
14 #include "net/http/http_request_info.h" 11 #include "net/http/http_request_info.h"
15 #include "net/http/http_response_headers.h"
16 #include "net/http/http_response_info.h"
17 12
18 namespace net { 13 namespace net {
19 14
20 void BuildTunnelRequest( 15 void BuildTunnelRequest(
21 const HttpRequestInfo& request_info, 16 const HttpRequestInfo& request_info,
22 const HttpRequestHeaders& auth_headers, 17 const HttpRequestHeaders& auth_headers,
23 const HostPortPair& endpoint, 18 const HostPortPair& endpoint,
24 std::string* request_line, 19 std::string* request_line,
25 HttpRequestHeaders* request_headers) { 20 HttpRequestHeaders* request_headers) {
26 // RFC 2616 Section 9 says the Host request-header field MUST accompany all 21 // RFC 2616 Section 9 says the Host request-header field MUST accompany all
27 // HTTP/1.1 requests. Add "Proxy-Connection: keep-alive" for compat with 22 // HTTP/1.1 requests. Add "Proxy-Connection: keep-alive" for compat with
28 // HTTP/1.0 proxies such as Squid (required for NTLM authentication). 23 // HTTP/1.0 proxies such as Squid (required for NTLM authentication).
29 *request_line = StringPrintf( 24 *request_line = StringPrintf(
30 "CONNECT %s HTTP/1.1\r\n", endpoint.ToString().c_str()); 25 "CONNECT %s HTTP/1.1\r\n", endpoint.ToString().c_str());
31 request_headers->SetHeader(HttpRequestHeaders::kHost, 26 request_headers->SetHeader(HttpRequestHeaders::kHost,
32 GetHostAndOptionalPort(request_info.url)); 27 GetHostAndOptionalPort(request_info.url));
33 request_headers->SetHeader(HttpRequestHeaders::kProxyConnection, 28 request_headers->SetHeader(HttpRequestHeaders::kProxyConnection,
34 "keep-alive"); 29 "keep-alive");
35 30
36 std::string user_agent; 31 std::string user_agent;
37 if (request_info.extra_headers.GetHeader(HttpRequestHeaders::kUserAgent, 32 if (request_info.extra_headers.GetHeader(HttpRequestHeaders::kUserAgent,
38 &user_agent)) 33 &user_agent))
39 request_headers->SetHeader(HttpRequestHeaders::kUserAgent, user_agent); 34 request_headers->SetHeader(HttpRequestHeaders::kUserAgent, user_agent);
40 35
41 request_headers->MergeFrom(auth_headers); 36 request_headers->MergeFrom(auth_headers);
42 } 37 }
43 38
44 int HandleAuthChallenge(HttpAuthController *auth,
45 HttpResponseInfo* response,
46 const BoundNetLog& net_log) {
47 DCHECK(response->headers);
48
49 int rv = auth->HandleAuthChallenge(response->headers, false, true, net_log);
50 response->auth_challenge = auth->auth_info();
51 if (rv == OK)
52 return ERR_PROXY_AUTH_REQUESTED;
53
54 return rv;
55 }
56
57 } // namespace net 39 } // namespace net
OLDNEW
« no previous file with comments | « net/http/http_proxy_utils.h ('k') | net/http/http_stream_factory_impl_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698