Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Unified Diff: chrome/browser/resources/options/intents_list.js

Issue 8608007: cr/ui/list.js: Support rows with variable heights. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Omit the custom lead item height Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/options/cookies_list.js ('k') | chrome/browser/resources/shared/js/cr/ui/grid.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/intents_list.js
diff --git a/chrome/browser/resources/options/intents_list.js b/chrome/browser/resources/options/intents_list.js
index 28e722d1646eca2c423c2536984771f15c1293c9..e2dc21e65414bb42d96bb5d413aed8935e3f8777 100644
--- a/chrome/browser/resources/options/intents_list.js
+++ b/chrome/browser/resources/options/intents_list.js
@@ -115,7 +115,6 @@ cr.define('options', function() {
this.dataChild.hidden = true;
} else {
if (this.list.expandedItem == this) {
- this.list.leadItemHeight = 0;
this.list.expandedItem = null;
}
this.style.height = '';
@@ -169,8 +168,6 @@ cr.define('options', function() {
this.classList.remove('measure-items');
this.itemsChild.style.height = itemsHeight + 'px';
this.style.height = fixedHeight + 'px';
- if (this.expanded)
- this.list.leadItemHeight = fixedHeight;
},
/**
@@ -497,6 +494,7 @@ cr.define('options', function() {
sm.addEventListener('change', this.cookieSelectionChange_.bind(this));
sm.addEventListener('leadIndexChange', this.cookieLeadChange_.bind(this));
this.selectionModel = sm;
+ this.fixedHeight = false;
},
/**
« no previous file with comments | « chrome/browser/resources/options/cookies_list.js ('k') | chrome/browser/resources/shared/js/cr/ui/grid.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698