cr/ui/list.js: Support rows with variable heights.

chrome/browser/resources/task_manager/main.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @constructor */
 function TaskManager() { }
 
 cr.addSingletonGetter(TaskManager);
 
 /*
@@ skipping 301 matching lines @@
     }
 
     this.table_ = this.dialogDom_.querySelector('.detail-table');
     cr.ui.Table.decorate(this.table_);
 
     this.table_.dataModel = this.dataModel_;
     this.table_.selectionModel = this.selectionModel_;
     this.table_.columnModel = this.columnModel_;
 
     // Expands height of row when a process has some tasks.
-    this.table_.autoExpands = true;
+    this.table_.fixedHeight = false;
 
     this.table_.list.addEventListener('contextmenu',
                                       this.onTableContextMenuOpened_.bind(this),
                                       true);
 
     // Sets custom row render function.
     this.table_.setRenderFunction(this.renderRow_.bind(this));
   },
 
   renderRow_: function(dataItem, table) {
@@ skipping 13 matching lines @@
 
       listItem.appendChild(cell);
     }
     listItem.data = dataItem;
 
     return listItem;
   },
 
   renderColumn_: function(entry, columnId, table) {
     var container = this.document_.createElement('div');
-    container.id = 'detail-container-' + columnId + '-pid' + entry.processId;
     container.className = 'detail-container-' + columnId;
 
-    if (entry[columnId]) {
+    if (entry && entry[columnId]) {
+      container.id = 'detail-container-' + columnId + '-pid' + entry.processId;
+
       for (var i = 0; i < entry[columnId].length; i++) {
         var label = document.createElement('div');
         if (columnId == 'title') {
           var image = this.document_.createElement('img');
           image.className = 'detail-title-image';
           image.src = entry['icon'][i];
           label.appendChild(image);
           var text = this.document_.createElement('div');
           text.className = 'detail-title-text';
           text.textContent = entry['title'][i];
@@ skipping 18 matching lines @@
     }
     return container;
   },
 
   onTaskChange: function (start, length, tasks) {
     var dm = this.dataModel_;
     var sm = this.selectionModel_;
     if (!dm || !sm)
       return;
 
+    this.table_.list.startBatchUpdates();
     // Splice takes the to-be-spliced-in array as individual parameters,
     // rather than as an array, so we need to perform some acrobatics...
     var args = [].slice.call(tasks);
-    args.unshift(start, length);
+    args.unshift(start, dm.length);
 
+    sm.beginChange();
     var oldSelectedIndexes = sm.selectedIndexes;
+
     dm.splice.apply(dm, args);
+
     sm.selectedIndexes = oldSelectedIndexes;
+    sm.endChange();
+    this.table_.list.endBatchUpdates();
   },
 
   onTaskAdd: function (start, length, tasks) {
     var dm = this.dataModel_;
     if (!dm)
       return;
 
     // Splice takes the to-be-spliced-in array as individual parameters,
     // rather than as an array, so we need to perform some acrobatics...
     var args = [].slice.call(tasks);
@@ skipping 146 matching lines @@
   taskmanager.onTaskChange(start, length, tasks);
 }
 
 function taskRemoved(start, length) {
   // Sometimes this can get called too early.
   if (!taskmanager)
     return;
   taskmanager.onTaskRemove(start, length);
 }