cr/ui/list.js: Support rows with variable heights.

chrome/browser/resources/options/intents_list.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(gbillock): refactor this together with CookiesList once we have
 // a better sense from UX design what it'll look like and so what'll be shared.
 cr.define('options', function() {
   const DeletableItemList = options.DeletableItemList;
   const DeletableItem = options.DeletableItem;
   const ArrayDataModel = cr.ui.ArrayDataModel;
@@ skipping 97 matching lines @@
       if (expanded) {
         var oldExpanded = this.list.expandedItem;
         this.list.expandedItem = this;
         this.updateItems_();
         if (oldExpanded)
           oldExpanded.expanded = false;
         this.classList.add('show-items');
         this.dataChild.hidden = true;
       } else {
         if (this.list.expandedItem == this) {
-          this.list.leadItemHeight = 0;
           this.list.expandedItem = null;
         }
         this.style.height = '';
         this.itemsChild.style.height = '';
         this.classList.remove('show-items');
         this.dataChild.hidden = false;
       }
     },
 
     /**
@@ skipping 33 matching lines @@
       var itemsHeight = getItemHeight(this.itemsChild);
       var fixedHeight = getItemHeight(this) + itemsHeight - this.itemsHeight_;
       this.itemsChild.style.height = this.itemsHeight_ + 'px';
       // Force relayout before enabling animation, so that if we have
       // changed things since the last layout, they will not be animated
       // during subsequent layouts.
       this.itemsChild.offsetHeight;
       this.classList.remove('measure-items');
       this.itemsChild.style.height = itemsHeight + 'px';
       this.style.height = fixedHeight + 'px';
-      if (this.expanded)
-        this.list.leadItemHeight = fixedHeight;
     },
 
     /**
      * Updates the origin summary to reflect changes in its items.
      * Both IntentsListItem and IntentsTreeNode implement this API.
      * This implementation scans the descendants to update the text.
      */
     updateOrigin: function() {
       var text = '';
       for (var i = 0; i < this.origin.children.length; ++i) {
@@ skipping 306 matching lines @@
     decorate: function() {
       DeletableItemList.prototype.decorate.call(this);
       this.classList.add('intents-list');
       this.data_ = [];
       this.dataModel = new ArrayDataModel(this.data_);
       this.addEventListener('keydown', this.handleKeyLeftRight_.bind(this));
       var sm = new ListSingleSelectionModel();
       sm.addEventListener('change', this.cookieSelectionChange_.bind(this));
       sm.addEventListener('leadIndexChange', this.cookieLeadChange_.bind(this));
       this.selectionModel = sm;
+      this.fixedHeight = false;
     },
 
     /**
      * Handles key down events and looks for left and right arrows, then
      * dispatches to the currently expanded item, if any.
      * @param {Event} e The keydown event.
      * @private
      */
     handleKeyLeftRight_: function(e) {
       var id = e.keyIdentifier;
@@ skipping 190 matching lines @@
       parent.clear();
       this.addByParent_(parent, 0, children);
       parent.endBatchUpdates();
     },
   };
 
   return {
     IntentsList: IntentsList
   };
 });