Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 8608005: Check for NULL pointer before assigning the test data (Closed)

Created:
9 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
9 years, 1 month ago
Reviewers:
jam, jeremy
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Check for NULL pointer before assigning the test data BUG=none TEST=MacSandboxTest.FileAccess works when run alone Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111197

Patch Set 1 #

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M content/common/sandbox_mac_unittest_helper.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/common/sandbox_mac_unittest_helper.mm View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jochen (gone - plz use gerrit)
plz review (getenv() will return NULL if the key is not present. SetTestData will then ...
9 years, 1 month ago (2011-11-21 09:28:49 UTC) #1
jeremy
Thanks for catching this! Could you add a comment to the RunTestInSandbox() in the .h ...
9 years, 1 month ago (2011-11-22 10:38:14 UTC) #2
jochen (gone - plz use gerrit)
John, could you please rubber-stamp?
9 years, 1 month ago (2011-11-22 10:42:22 UTC) #3
jam
lgtm
9 years, 1 month ago (2011-11-22 18:09:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/8608005/4001
9 years, 1 month ago (2011-11-22 18:14:29 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-22 19:52:37 UTC) #6
Change committed as 111197

Powered by Google App Engine
This is Rietveld 408576698