Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 8608001: CrOs: Remove 30 static initializers and 30 exit time destructors (Closed)

Created:
9 years, 1 month ago by Nico
Modified:
9 years, 1 month ago
CC:
chromium-reviews, achuith+watch_chromium.org, nkostylev+watch_chromium.org, tbarzic+watch_chromium.org, tbarzic
Visibility:
Public.

Description

CrOs: Remove 30 static initializers and 30 exit time destructors Also remove a few unused strings. BUG=101600, 94925 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110867

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -20 lines) Patch
M chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc View 1 2 2 chunks +4 lines, -4 lines 2 comments Download
M chrome/browser/ui/webui/chromeos/imageburner/imageburner_utils.h View 1 2 1 chunk +4 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/imageburner/imageburner_utils.cc View 1 2 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
9 years, 1 month ago (2011-11-20 22:30:36 UTC) #1
Ryan Sleevi
http://codereview.chromium.org/8608001/diff/3/chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc File chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc (right): http://codereview.chromium.org/8608001/diff/3/chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc#newcode48 chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc:48: namespace { Why did you move the namespace down? ...
9 years, 1 month ago (2011-11-20 23:01:39 UTC) #2
Ryan Sleevi
lgtm
9 years, 1 month ago (2011-11-20 23:02:03 UTC) #3
Nico
thanks! http://codereview.chromium.org/8608001/diff/3/chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc File chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc (right): http://codereview.chromium.org/8608001/diff/3/chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc#newcode48 chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc:48: namespace { On 2011/11/20 23:01:39, Ryan Sleevi wrote: ...
9 years, 1 month ago (2011-11-20 23:14:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8608001/3
9 years, 1 month ago (2011-11-20 23:14:10 UTC) #5
commit-bot: I haz the power
Change committed as 110867
9 years, 1 month ago (2011-11-21 00:21:44 UTC) #6
Mark Mentovai
9 years, 1 month ago (2011-11-21 13:36:44 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld 408576698