Issue 8607002: gtk: Move DownloadShelfGtk data member to private section of BrowserWindowGtk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8607002: gtk: Move DownloadShelfGtk data member to private section of BrowserWindowGtk. (Closed)

Created:
9 years, 1 month ago by tfarina

Modified:
9 years, 1 month ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gtk: Move DownloadShelfGtk data member to private section of BrowserWindowGtk. R=erg@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111351

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome/browser/ui/gtk/browser_window_gtk.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

9 years, 1 month ago (2011-11-21 17:50:11 UTC) #2

lgtm i guess

(Changes like this make me nervous because you're changing destruction order. it
looks like the tests went green anyway though, which is a big part of why I feel
comfortable enough lgtming this...)

Expand Messages | Collapse Messages