Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1617)

Unified Diff: views/controls/combobox/combobox.h

Issue 8607001: views: Factor out Listener from Combobox into its own header file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: views/controls/combobox/combobox.h
diff --git a/views/controls/combobox/combobox.h b/views/controls/combobox/combobox.h
index a58268897207aac98d0070b2a8a6b247ba507fdc..85791226b1b03f0f710ab89d9e2a83f62468f6a1 100644
--- a/views/controls/combobox/combobox.h
+++ b/views/controls/combobox/combobox.h
@@ -18,29 +18,20 @@ class ComboboxModel;
namespace views {
+class ComboboxListener;
+
// A non-editable combo-box (aka a drop-down list)
class VIEWS_EXPORT Combobox : public View {
public:
// The combobox's class name.
static const char kViewClassName[];
- class Listener {
- public:
- // This is invoked once the selected item changed.
- virtual void ItemChanged(Combobox* combo_box,
- int prev_index,
- int new_index) = 0;
-
- protected:
- virtual ~Listener() {}
- };
-
// |model| is not owned by the combo box.
explicit Combobox(ui::ComboboxModel* model);
virtual ~Combobox();
// Register |listener| for item change events.
- void set_listener(Listener* listener) {
+ void set_listener(ComboboxListener* listener) {
listener_ = listener;
}
@@ -94,8 +85,8 @@ class VIEWS_EXPORT Combobox : public View {
// Our model.
ui::ComboboxModel* model_;
- // Item change listener.
- Listener* listener_;
+ // The combobox's listener. Notified when the selected item change.
+ ComboboxListener* listener_;
// The current selection.
int selected_item_;

Powered by Google App Engine
This is Rietveld 408576698