Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8038)

Unified Diff: chrome/browser/ui/webui/bidi_checker_web_ui_test.h

Issue 8606009: Revert 110861 - Adding more bidichecker tests and doing some minor cleanups. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/bidi_checker_web_ui_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/bidi_checker_web_ui_test.h
===================================================================
--- chrome/browser/ui/webui/bidi_checker_web_ui_test.h (revision 110898)
+++ chrome/browser/ui/webui/bidi_checker_web_ui_test.h (working copy)
@@ -15,29 +15,27 @@
public:
virtual ~WebUIBidiCheckerBrowserTest();
- protected:
- WebUIBidiCheckerBrowserTest();
-
// Runs the Bidi Checker on the given page URL. |isRTL| should be true when
// the active page locale is RTL.
void RunBidiCheckerOnPage(const char pageURL[], bool isRTL);
+ protected:
+ WebUIBidiCheckerBrowserTest();
+
// Setup test path.
virtual void SetUpInProcessBrowserTestFixture() OVERRIDE;
};
-// Base class for BidiChecker-based tests that run with an LTR UI.
-class WebUIBidiCheckerBrowserTestLTR : public WebUIBidiCheckerBrowserTest {
- public:
- void RunBidiCheckerOnPage(const char pageURL[]);
-};
-
// Base class for BidiChecker-based tests that run with an RTL UI.
-class WebUIBidiCheckerBrowserTestRTL : public WebUIBidiCheckerBrowserTest {
+// Preloads the BidiChecker JS library for each test, as well as modifies the
+// active language.
+class WebUIBidiCheckerBrowserTestFakeBidi : public WebUIBidiCheckerBrowserTest {
public:
- void RunBidiCheckerOnPage(const char pageURL[]);
+ virtual ~WebUIBidiCheckerBrowserTestFakeBidi();
protected:
+ WebUIBidiCheckerBrowserTestFakeBidi();
+
virtual void SetUpOnMainThread() OVERRIDE;
virtual void CleanUpOnMainThread() OVERRIDE;
« no previous file with comments | « no previous file | chrome/browser/ui/webui/bidi_checker_web_ui_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698