Issue 8606009: Revert 110861 - Adding more bidichecker tests and doing some minor cleanups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8606009: Revert 110861 - Adding more bidichecker tests and doing some minor cleanups. (Closed)

Created:
9 years, 1 month ago by Nikita (slow)

Modified:
9 years, 1 month ago

Reviewers:
jeremy

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 110861 - Adding more bidichecker tests and doing some minor cleanups. These tests are constantly failing on Linux ChromeOS bot (chromium.chromiumos waterfall): TestBugReportPage, TestSettingsLanguageOptionsPage. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/8228009 TBR=jeremy@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110899

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+114 lines, -328 lines)			Patch
M	chrome/browser/ui/webui/bidi_checker_web_ui_test.h	View	1 chunk	+9 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/webui/bidi_checker_web_ui_test.cc	View	5 chunks	+100 lines, -267 lines	0 comments	Download
M	chrome/test/data/webui/bidichecker_tests.js	View	3 chunks	+5 lines, -50 lines	0 comments	Download

Total messages: 2 (0 generated)

Nikita (slow)

9 years, 1 month ago (2011-11-21 11:06:26 UTC) #2

Failures could be seen here:
http://build.chromium.org/p/chromium.chromiumos/waterfall?show=Linux%20ChromeOS