Linux/Gtk: Drag source should not delete source data on drop success on omnibox.

Linux/Gtk: Drag source should not delete source data on drag finish in omnibox.

BUG=104946
.
TEST=As described in the bug.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112960

[SanjoyPal, 2011-11-21 07:44:41]

PTAL.

[SanjoyPal, 2011-11-30 11:22:59]

Can anyone please review this patch?

[James Hawkins, 2011-11-30 16:14:11]

What is the behavior on Mac and Windows Chrome?

[SanjoyPal, 2011-12-01 08:11:16]

On 2011/11/30 16:14:11, James Hawkins wrote:
> What is the behavior on Mac and Windows Chrome?

Mac and Windows chrome works fine. The text is not deleted from Text
Editor/Wordpad on dropping text on omnibox.

In Linux ubuntu, this bug is reproducible using any Gtk based application having
a textfield/text area (e.g Text Editor, Calculator, Notes).

[James Hawkins, 2011-12-01 17:14:09]

On 2011/12/01 08:11:16, SanjoyPal wrote:
> On 2011/11/30 16:14:11, James Hawkins wrote:
> > What is the behavior on Mac and Windows Chrome?
> 
> Mac and Windows chrome works fine. The text is not deleted from Text
> Editor/Wordpad on dropping text on omnibox.
> 
> In Linux ubuntu, this bug is reproducible using any Gtk based application
having
> a textfield/text area (e.g Text Editor, Calculator, Notes).

What do you mean by being reproducible?  Are you saying that in, e.g., Text
Editor you see the same behavior as Chrome Linux, i.e., dragging and dropping
text from an input field deletes the source?

[SanjoyPal, 2011-12-02 05:33:07]

On 2011/12/01 17:14:09, James Hawkins wrote:
> On 2011/12/01 08:11:16, SanjoyPal wrote:
> > On 2011/11/30 16:14:11, James Hawkins wrote:
> > > What is the behavior on Mac and Windows Chrome?
> > 
> > Mac and Windows chrome works fine. The text is not deleted from Text
> > Editor/Wordpad on dropping text on omnibox.
> > 
> > In Linux ubuntu, this bug is reproducible using any Gtk based application
> having
> > a textfield/text area (e.g Text Editor, Calculator, Notes).
> 
> What do you mean by being reproducible?  Are you saying that in, e.g., Text
> Editor you see the same behavior as Chrome Linux, i.e., dragging and dropping
> text from an input field deletes the source?
No. I don't mean that. 

I mean, dragging text from  Text Editor, Calculator, Notes etc and dropping it
on chrome omnibox, deletes the source text (dragged text) from Text Editor,
Calculator, Notes.

[James Hawkins, 2011-12-02 16:59:32]

On 2011/12/02 05:33:07, SanjoyPal wrote:
> On 2011/12/01 17:14:09, James Hawkins wrote:
> > On 2011/12/01 08:11:16, SanjoyPal wrote:
> > > On 2011/11/30 16:14:11, James Hawkins wrote:
> > > > What is the behavior on Mac and Windows Chrome?
> > > 
> > > Mac and Windows chrome works fine. The text is not deleted from Text
> > > Editor/Wordpad on dropping text on omnibox.
> > > 
> > > In Linux ubuntu, this bug is reproducible using any Gtk based application
> > having
> > > a textfield/text area (e.g Text Editor, Calculator, Notes).
> > 
> > What do you mean by being reproducible?  Are you saying that in, e.g., Text
> > Editor you see the same behavior as Chrome Linux, i.e., dragging and
dropping
> > text from an input field deletes the source?
> No. I don't mean that. 
> 
> I mean, dragging text from  Text Editor, Calculator, Notes etc and dropping it
> on chrome omnibox, deletes the source text (dragged text) from Text Editor,
> Calculator, Notes.

OK; we just said the same thing.  To me that's evidence that we are currently
doing the right thing to match platform behavior.

[SanjoyPal, 2011-12-02 18:27:13]

On 2011/12/02 16:59:32, James Hawkins wrote:

But as i said ealier, the behavior in linux is just opposite as that of Windows
and Mac. The dragged text is not deleted in Mac and Windows.

With this patch we can have same behavior in linux also.

Can you please try the use case as described in bug once?

[James Hawkins, 2011-12-02 18:28:22]

Elliot: What is your opinion about matching the platform behavior versus
matching Chrome on Mac/Win here?

[Elliot Glaysher, 2011-12-02 19:23:20]

On 2011/12/02 18:28:22, James Hawkins wrote:
> Elliot: What is your opinion about matching the platform behavior versus
> matching Chrome on Mac/Win here?

We should match platform behavior here.

In linux firefox, dragging a URL from gedit to the firefox url bar: text is
copied. In linux chromium (17.0.942.0 dev), dragging a URL from gedit to the
omnibox: text is deleted in gedit.

[SanjoyPal, 2011-12-03 13:00:43]

On 2011/12/02 19:23:20, Elliot Glaysher wrote:

James, Elliot: This patch exactly fixes this issue in linux chromium. Can you
please LGTM the patch? Thanks

[James Hawkins, 2011-12-04 18:06:49]

Gotcha, I got lost in all the variables.

LGTM

[commit-bot: I haz the power, 2011-12-05 05:25:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ncj674@motorola.com/8606007/1

[commit-bot: I haz the power, 2011-12-05 08:23:09]

Change committed as 112960