Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 8606006: Adds support for capture device enumeration on Windows. (Closed)

Created:
9 years, 1 month ago by henrika (OOO until Aug 14)
Modified:
9 years, 1 month ago
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, Paweł Hajdan Jr., vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org
Visibility:
Public.

Description

Adds support for capture device enumeration on Windows. Example output (two devices found on Windows 7 machine): device_name: Microphone (6- SB Arena Headset) unique_id: {0.0.1.00000000}.{24515814-26fd-4382-b4bc-0a8d847ed853} device_name: Microphone (Realtek High Definition Audio) unique_id: {0.0.1.00000000}.{8db6020f-18e3-4f25-b6f5-7726c9122574} BUG=None TEST=audio_input_device_unittest.cc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111500

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : Added possibility to set enumeration API on Windows #

Patch Set 4 : Added Wave support and cleaned up the code #

Total comments: 24

Patch Set 5 : Added missing header file #

Patch Set 6 : Changes based on review by Tommmi #

Patch Set 7 : nit #

Total comments: 2

Patch Set 8 : Linux fix #

Patch Set 9 : Rebase and fix lint warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -21 lines) Patch
M media/audio/audio_input_device_unittest.cc View 1 2 3 4 5 6 7 8 1 chunk +126 lines, -13 lines 0 comments Download
M media/audio/win/audio_manager_win.h View 1 2 3 4 5 6 7 8 3 chunks +18 lines, -1 line 0 comments Download
M media/audio/win/audio_manager_win.cc View 1 2 3 4 5 6 7 8 3 chunks +22 lines, -7 lines 0 comments Download
A media/audio/win/device_enumeration_win.h View 1 2 3 1 chunk +26 lines, -0 lines 0 comments Download
A media/audio/win/device_enumeration_win.cc View 1 2 3 4 5 1 chunk +125 lines, -0 lines 0 comments Download
M media/media.gyp View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tommi (sloooow) - chröme
(adding myself to the reviewers list) Hey Henrik - I'm looking into whether it's possible ...
9 years, 1 month ago (2011-11-21 18:53:41 UTC) #1
henrika_dont_use
Does your question relate to the test or the actual implementation? There is no fall-back ...
9 years, 1 month ago (2011-11-21 20:04:13 UTC) #2
henrika (OOO until Aug 14)
Eugene, adding you as owner in media. Please take a quick look. Note that this ...
9 years, 1 month ago (2011-11-22 11:49:44 UTC) #3
tommi (sloooow) - chröme
http://codereview.chromium.org/8606006/diff/15001/media/audio/audio_input_device_unittest.cc File media/audio/audio_input_device_unittest.cc (right): http://codereview.chromium.org/8606006/diff/15001/media/audio/audio_input_device_unittest.cc#newcode26 media/audio/audio_input_device_unittest.cc:26: if (AudioManagerWin::enumeration_type() == is this stored in a global ...
9 years, 1 month ago (2011-11-22 12:52:37 UTC) #4
henrika (OOO until Aug 14)
Rewrote large parts of the tests and answered all comments. http://codereview.chromium.org/8606006/diff/15001/media/audio/audio_input_device_unittest.cc File media/audio/audio_input_device_unittest.cc (right): http://codereview.chromium.org/8606006/diff/15001/media/audio/audio_input_device_unittest.cc#newcode26 ...
9 years, 1 month ago (2011-11-23 09:19:19 UTC) #5
tommi (sloooow) - chröme
lgtm http://codereview.chromium.org/8606006/diff/24008/media/audio/audio_input_device_unittest.cc File media/audio/audio_input_device_unittest.cc (right): http://codereview.chromium.org/8606006/diff/24008/media/audio/audio_input_device_unittest.cc#newcode77 media/audio/audio_input_device_unittest.cc:77: it->device_name); indent http://codereview.chromium.org/8606006/diff/24008/media/audio/win/audio_manager_win.cc File media/audio/win/audio_manager_win.cc (right): http://codereview.chromium.org/8606006/diff/24008/media/audio/win/audio_manager_win.cc#newcode310 media/audio/win/audio_manager_win.cc:310: ...
9 years, 1 month ago (2011-11-23 09:47:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/henrika@chromium.org/8606006/24010
9 years, 1 month ago (2011-11-23 10:23:19 UTC) #7
commit-bot: I haz the power
9 years, 1 month ago (2011-11-23 11:40:56 UTC) #8
Try job failure for 8606006-24010 (retry) on mac_rel for step "media_unittests".
It's a second try, previously, step "media_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698