Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Issue 8605006: Relands: Fixes bug where clock button wasn't updating in response to a (Closed)

Created:
9 years, 1 month ago by sky
Modified:
9 years, 1 month ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Relands: Fixes bug where clock button wasn't updating in response to a timezone change. BUG=104667 TEST=none R=ben@chromium.org,stevenjb@chromium.org TBR=ben@chromium.org,stevenjb@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110851

Patch Set 1 #

Patch Set 2 : Original patch #

Patch Set 3 : Da fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -10 lines) Patch
M chrome/browser/chromeos/status/clock_menu_button_browsertest.cc View 2 chunks +13 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/status/status_area_view_chromeos.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/chromeos/status/status_area_view_chromeos.cc View 3 chunks +7 lines, -3 lines 0 comments Download
A chrome/browser/chromeos/status/timezone_clock_updater.h View 1 chunk +30 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/status/timezone_clock_updater.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/aura/chrome_shell_delegate.h View 2 chunks +11 lines, -1 line 0 comments Download
M chrome/browser/ui/views/aura/chrome_shell_delegate.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/aura/status_area_host_aura.h View 2 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/aura/status_area_host_aura.cc View 3 chunks +13 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sky
TBRing since this is a single #ifdef. Patchset 2 is the original patch.
9 years, 1 month ago (2011-11-19 23:22:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/8605006/2011
9 years, 1 month ago (2011-11-19 23:22:59 UTC) #2
commit-bot: I haz the power
9 years, 1 month ago (2011-11-20 00:27:00 UTC) #3
Change committed as 110851

Powered by Google App Engine
This is Rietveld 408576698