Print Preview: Fixing code style issues reported by gsjlint.

chrome/browser/resources/print_preview/print_preview.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // require: cr/ui/print_preview_cloud.js
 
 var localStrings = new LocalStrings();
 
 // If useCloudPrint is true we attempt to connect to cloud print
 // and populate the list of printers with cloud print printers.
@@ skipping 107 matching lines @@
   MARGINS_MAY_HAVE_CHANGED: 'marginsMayHaveChanged',
   // Fired when a pdf generation related error occurs.
   PDF_GENERATION_ERROR: 'PDFGenerationError',
   // Fired once the first page of the pdf document is loaded in the plugin.
   PDF_LOADED: 'PDFLoaded',
   // Fired when the selected printer capabilities change.
   PRINTER_CAPABILITIES_UPDATED: 'printerCapabilitiesUpdated',
   // Fired when the print button needs to be updated.
   UPDATE_PRINT_BUTTON: 'updatePrintButton',
   // Fired when the print summary needs to be updated.
-  UPDATE_SUMMARY: 'updateSummary',
-}
+  UPDATE_SUMMARY: 'updateSummary'
+};
 
 /**
  * Window onload handler, sets up the page and starts print preview by getting
  * the printer list.
  */
 function onLoad() {
   cr.enablePlatformSpecificCSSRules();
   initialPreviewRequestID = randomInteger(MIN_REQUEST_ID, MAX_REQUEST_ID);
   lastPreviewRequestID = initialPreviewRequestID;
 
@@ skipping 28 matching lines @@
   marginSettings = print_preview.MarginSettings.getInstance();
   headerFooterSettings = print_preview.HeaderFooterSettings.getInstance();
   colorSettings = print_preview.ColorSettings.getInstance();
   $('printer-list').onchange = updateControlsWithSelectedPrinterCapabilities;
 
   previewArea.showLoadingAnimation();
   chrome.send('getInitialSettings');
 }
 
 /**
- * @param {string} initiatorTabTitle The title of the initiator tab.
  * @param {object} initialSettings An object containing all the initial
  *     settings.
  */
 function setInitialSettings(initialSettings) {
   setInitiatorTabTitle(initialSettings['initiatorTabTitle']);
   previewModifiable = initialSettings['previewModifiable'];
   if (previewModifiable) {
     print_preview.MarginSettings.setNumberFormatAndMeasurementSystem(
         initialSettings['numberFormat'],
         initialSettings['measurementSystem']);
@@ skipping 152 matching lines @@
  */
 function reloadPrintersList() {
   $('printer-list').length = 0;
   firstCloudPrintOptionPos = 0;
   lastCloudPrintOptionPos = 0;
   chrome.send('getPrinters');
 }
 
 /**
  * Turn on the integration of Cloud Print.
- * @param {string} cloudPrintUrl The URL to use for cloud print servers.
+ * @param {string} cloudPrintURL The URL to use for cloud print servers.
  */
 function setUseCloudPrint(cloudPrintURL) {
   useCloudPrint = true;
   cloudprint.setBaseURL(cloudPrintURL);
 }
 
 /**
  * Take the PDF data handed to us and submit it to the cloud, closing the print
  * preview tab once the upload is successful.
  * @param {string} data Data to send as the print job.
@@ skipping 107 matching lines @@
 function isExpectedPreviewResponse(previewResponseId) {
   return lastPreviewRequestID == previewResponseId;
 }
 
 /**
  * Returns the name of the selected printer or the empty string if no
  * printer is selected.
  * @return {string} The name of the currently selected printer.
  */
 function getSelectedPrinterName() {
-  var printerList = $('printer-list')
+  var printerList = $('printer-list');
   var selectedPrinter = printerList.selectedIndex;
   if (selectedPrinter < 0)
     return '';
   return printerList.options[selectedPrinter].value;
 }
 
 /**
  * Asks the browser to print the preview PDF based on current print
  * settings. If the preview is still loading, printPendingFile() will get
  * called once the preview loads.
@@ skipping 114 matching lines @@
 function fileSelectionCompleted() {
   // If the file selection is completed and the tab is not already closed it
   // means that a pending print to pdf request exists.
   disableInputElementsInSidebar();
   previewArea.showCustomMessage(
       localStrings.getString('printingToPDFInProgress'));
 }
 
 /**
  * Set the default printer. If there is one, generate a print preview.
- * @param {string} printer Name of the default printer. Empty if none.
+ * @param {string} printerName Name of the default printer. Empty if none.
  * @param {string} cloudPrintData Cloud print related data to restore if
  *     the default printer is a cloud printer.
  */
 function setDefaultPrinter(printerName, cloudPrintData) {
   // Add a placeholder value so the printer list looks valid.
   addDestinationListOption('', '', true, true, true);
   if (printerName) {
     defaultOrLastUsedPrinterName = printerName;
     if (cloudPrintData) {
       cloudprint.setDefaultPrinter(printerName,
@@ skipping 83 matching lines @@
     option.setAttribute('role', 'separator');
   return option;
 }
 
 /**
  * Adds an option to the printer destination list.
  * @param {string} optionText specifies the option text content.
  * @param {string} optionValue specifies the option value.
  * @param {boolean} isDefault is true if the option needs to be selected.
  * @param {boolean} isDisabled is true if the option needs to be disabled.
+ * @param {boolean} isSeparator is true if the option serves just as a
+ *     separator.
  * @return {Object} The created option.
  */
 function addDestinationListOption(optionText, optionValue, isDefault,
     isDisabled, isSeparator) {
   var option = createDestinationListOption(optionText,
                                            optionValue,
                                            isDefault,
                                            isDisabled,
                                            isSeparator);
   $('printer-list').add(option);
   return option;
 }
 
 /**
  * Adds an option to the printer destination list at a specified position.
  * @param {number} position The index in the printer-list wher the option
        should be created.
  * @param {string} optionText specifies the option text content.
  * @param {string} optionValue specifies the option value.
  * @param {boolean} isDefault is true if the option needs to be selected.
  * @param {boolean} isDisabled is true if the option needs to be disabled.
+ * @param {boolean} isSeparator is true if the option is a visual separator and
+ *     needs to be disabled.
  * @return {Object} The created option.
  */
 function addDestinationListOptionAtPosition(position,
                                             optionText,
                                             optionValue,
                                             isDefault,
                                             isDisabled,
                                             isSeparator) {
   var option = createDestinationListOption(optionText,
                                            optionValue,
@@ skipping 121 matching lines @@
  * @param {number} previewResponseId The preview request id that resulted in
  *     this response.
  */
 function reloadPreviewPages(previewUid, previewResponseId) {
   if (!isExpectedPreviewResponse(previewResponseId))
     return;
 
   cr.dispatchSimpleEvent(document, customEvents.UPDATE_PRINT_BUTTON);
   checkAndHideOverlayLayerIfValid();
   var pageSet = pageSettings.previouslySelectedPages;
-  for (var i = 0; i < pageSet.length; i++)
-    $('pdf-viewer').loadPreviewPage(getPageSrcURL(previewUid, pageSet[i]-1), i);
+  for (var i = 0; i < pageSet.length; i++) {
+    $('pdf-viewer').loadPreviewPage(
+        getPageSrcURL(previewUid, pageSet[i] - 1), i);
+  }
 
   hasPendingPreviewRequest = false;
   isPrintReadyMetafileReady = true;
   previewArea.pdfLoaded = true;
   sendPrintDocumentRequestIfNeeded();
 }
 
 /**
  * Notification that a print preview page has been rendered.
  * Check if the settings have changed and request a regeneration if needed.
@@ skipping 29 matching lines @@
     hasPendingPreviewRequest = false;
     if (pageIndex != 0)
       sendPrintDocumentRequestIfNeeded();
   }
 }
 
 /**
  * Update the print preview when new preview data is available.
  * Create the PDF plugin as needed.
  * Called from PrintPreviewUI::PreviewDataIsAvailable().
- * @param {boolean} modifiable If the preview is modifiable.
  * @param {string} previewUid Preview unique identifier.
  * @param {number} previewResponseId The preview request id that resulted in
  *     this response.
  */
 function updatePrintPreview(previewUid, previewResponseId) {
   if (!isExpectedPreviewResponse(previewResponseId))
     return;
   isPrintReadyMetafileReady = true;
 
   if (!previewModifiable) {
@@ skipping 120 matching lines @@
   for (var i = 0; i < pluginInterface.length; i++) {
     if (!pluginInterface[i])
       return false;
   }
   return true;
 }
 
 /**
  * Sets the default values and sends a request to regenerate preview data.
  * Resets the margin options only if |resetMargins| is true.
+ * @param {boolean} resetMargins True if margin settings should be resetted.
  */
 function setDefaultValuesAndRegeneratePreview(resetMargins) {
   if (resetMargins)
     marginSettings.resetMarginsIfNeeded();
   pageSettings.resetState();
   requestPrintPreview();
 }
 
 /**
  * Class that represents the state of the print settings.
  */
 function PrintSettings() {
   this.deviceName = '';
   this.isLandscape = '';
   this.hasHeaderFooter = '';
 }
 
 /**
  *  Takes a snapshot of the print settings.
  */
 PrintSettings.prototype.save = function() {
   this.deviceName = getSelectedPrinterName();
   this.isLandscape = layoutSettings.isLandscape();
   this.hasHeaderFooter = headerFooterSettings.hasHeaderFooter();
-}
+};
 
 /**
  * Updates the title of the print preview tab according to |initiatorTabTitle|.
  * @param {string} initiatorTabTitle The title of the initiator tab.
  */
 function setInitiatorTabTitle(initiatorTabTitle) {
   if (initiatorTabTitle == '')
     return;
   document.title = localStrings.getStringF(
       'printPreviewTitleFormat', initiatorTabTitle);
@@ skipping 38 matching lines @@
 <include src="copies_settings.js"/>
 <include src="header_footer_settings.js"/>
 <include src="layout_settings.js"/>
 <include src="color_settings.js"/>
 <include src="margin_settings.js"/>
 <include src="margin_textbox.js"/>
 <include src="margin_utils.js"/>
 <include src="margins_ui.js"/>
 <include src="margins_ui_pair.js"/>
 <include src="preview_area.js"/>