move chromeos bubble setup code to window.cc

chrome/browser/ui/views/window.h

Index: chrome/browser/ui/views/window.h
diff --git a/chrome/browser/ui/views/window.h b/chrome/browser/ui/views/window.h
index 20ea532b3c653ba8d07ae0e3eea1cf8e51d32880..a090dc4de2ee915b2339d058d8ebacea07f4f340 100644
--- a/chrome/browser/ui/views/window.h
+++ b/chrome/browser/ui/views/window.h
@@ -9,6 +9,7 @@
 #include "ui/gfx/native_widget_types.h"
 
 namespace views {
+class BubbleDelegateView;
 class Widget;
 class WidgetDelegate;
 }
@@ -19,6 +20,19 @@ namespace browser {
 views::Widget* CreateViewsWindow(gfx::NativeWindow parent,
                                  views::WidgetDelegate* delegate);
 
+// Create a bubble for a given |delegate|. Takes care of chromeos
+// specific window type setting. For bubbles that do not run on
+// chromeos, use views::BubbleDelgateView::CreateBubble() directly.

[msw, 2011/11/22 00:31:52]

There's maybe 1-2 bubbles (CriticalNotificationBubble, ?) that don't run on
CrOS. Let's just run them all through this codepath, since it won't hurt
anything.

[Daniel Erat, 2011/11/22 00:36:10]

s/Delgate/Delegate/

[alicet1, 2011/11/22 00:56:58]

removed the last sentence.

[alicet1, 2011/11/22 00:56:58]

Done.

+views::Widget* CreateViewsBubble(views::BubbleDelegateView* delegate);
+
+#if defined(OS_CHROMEOS) && defined(TOOLKIT_USES_GTK)
+// Create a bubble that will show even when chromeos screen is locked,
+// for a given |delegate|. Takes care of chromeos specific window
+// type setting. For bubbles that do not need to be shown when screen
+// is locked, use CreateViewsBubble instead.
+views::Widget* CreateViewsBubbleScreenLocked(

[Daniel Erat, 2011/11/22 00:31:35]

this name is a bit awkward.  CreatePersistentViewsBubble(), maybe?

[alicet1, 2011/11/22 00:56:58]

Done.

+    views::BubbleDelegateView* delegate);
+#endif
 }  // namespace browser
 
 #endif  // CHROME_BROWSER_UI_VIEWS_WINDOW_H_