base::Bind() conversion for BrowserProcessImpl

base::Bind() conversion for BrowserProcessImpl

BUG=none
TEST=trybots


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110847

[willchan no longer on Chromium, 2011-11-19 20:58:24]

http://codereview.chromium.org/8604010/diff/1002/chrome/browser/browser_proce...
File chrome/browser/browser_process_impl.cc (right):

http://codereview.chromium.org/8604010/diff/1002/chrome/browser/browser_proce...
chrome/browser/browser_process_impl.cc:328: base::IgnoreReturn<bool>(
I'm not sure if the template parameter is necessary. If not, then it'll look
cleaner if you drop it and that would be my preference. If it's necessary, then
sure.

[willchan no longer on Chromium, 2011-11-19 20:58:35]

LGTM

On 2011/11/19 20:58:24, willchan wrote:
>
http://codereview.chromium.org/8604010/diff/1002/chrome/browser/browser_proce...
> File chrome/browser/browser_process_impl.cc (right):
> 
>
http://codereview.chromium.org/8604010/diff/1002/chrome/browser/browser_proce...
> chrome/browser/browser_process_impl.cc:328: base::IgnoreReturn<bool>(
> I'm not sure if the template parameter is necessary. If not, then it'll look
> cleaner if you drop it and that would be my preference. If it's necessary,
then
> sure.

[dcheng, 2011-11-19 21:15:23]

http://codereview.chromium.org/8604010/diff/1002/chrome/browser/browser_proce...
File chrome/browser/browser_process_impl.cc (right):

http://codereview.chromium.org/8604010/diff/1002/chrome/browser/browser_proce...
chrome/browser/browser_process_impl.cc:328: base::IgnoreReturn<bool>(
On 2011/11/19 20:58:24, willchan wrote:
> I'm not sure if the template parameter is necessary. If not, then it'll look
> cleaner if you drop it and that would be my preference. If it's necessary,
then
> sure.

It seems to be necessary in general... except in the bind unittest. Do you know
why type inference works for the unit test but not here?

[willchan no longer on Chromium, 2011-11-19 21:17:55]

http://codereview.chromium.org/8604010/diff/1002/chrome/browser/browser_proce...
File chrome/browser/browser_process_impl.cc (right):

http://codereview.chromium.org/8604010/diff/1002/chrome/browser/browser_proce...
chrome/browser/browser_process_impl.cc:328: base::IgnoreReturn<bool>(
On 2011/11/19 21:15:24, dcheng wrote:
> On 2011/11/19 20:58:24, willchan wrote:
> > I'm not sure if the template parameter is necessary. If not, then it'll look
> > cleaner if you drop it and that would be my preference. If it's necessary,
> then
> > sure.
> 
> It seems to be necessary in general... except in the bind unittest. Do you
know
> why type inference works for the unit test but not here?

Can you show me the compilation errors you encounter?

[dcheng, 2011-11-19 21:21:27]

http://codereview.chromium.org/8604010/diff/1002/chrome/browser/browser_proce...
File chrome/browser/browser_process_impl.cc (right):

http://codereview.chromium.org/8604010/diff/1002/chrome/browser/browser_proce...
chrome/browser/browser_process_impl.cc:328: base::IgnoreReturn<bool>(
On 2011/11/19 21:17:55, willchan wrote:
> On 2011/11/19 21:15:24, dcheng wrote:
> > On 2011/11/19 20:58:24, willchan wrote:
> > > I'm not sure if the template parameter is necessary. If not, then it'll
look
> > > cleaner if you drop it and that would be my preference. If it's necessary,
> > then
> > > sure.
> > 
> > It seems to be necessary in general... except in the bind unittest. Do you
> know
> > why type inference works for the unit test but not here?
> 
> Can you show me the compilation errors you encounter?

  CXX(target) out/Debug/obj.target/browser/chrome/browser/browser_process_impl.o
chrome/browser/browser_process_impl.cc: In member function 'virtual unsigned int
BrowserProcessImpl::ReleaseModule()':
chrome/browser/browser_process_impl.cc:329: error: no matching function for call
to
'IgnoreReturn(base::internal::InvokerStorageHolder<base::internal::InvokerStorage1<bool
(*)(bool), bool> >)'
make: *** [out/Debug/obj.target/browser/chrome/browser/browser_process_impl.o]
Error 1

[willchan no longer on Chromium, 2011-11-19 21:23:51]

+ajwong

It's not a big deal btw, so you should feel free to commit. But if Albert can
figure out why this happens and we can get rid of it, maybe we should follow up
with a cleanup CL. Whatever.

[commit-bot: I haz the power, 2011-11-19 21:32:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcheng@chromium.org/8604010/1002

[awong, 2011-11-19 22:11:42]

It's a known problem with IgnoreReturn().  The huge CL reimplementing Bind() was
meant to fix this.  I'll be making a cleanup pass after that is done.

-Albert
 

On 2011/11/19 21:23:51, willchan wrote:
> +ajwong
> 
> It's not a big deal btw, so you should feel free to commit. But if Albert can
> figure out why this happens and we can get rid of it, maybe we should follow
up
> with a cleanup CL. Whatever.

[commit-bot: I haz the power, 2011-11-19 22:43:47]

Change committed as 110847