Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8604005: Add OVERRIDE to chrome/browser/ui/webui/. (Closed)

Created:
9 years, 1 month ago by Avi (use Gerrit)
Modified:
9 years, 1 month ago
Reviewers:
James Hawkins
CC:
chromium-reviews, GeorgeY, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, tfarina, Erik does not do reviews, dhollowa, acolwell+watch_chromium.org, mihaip+watch_chromium.org, annacc+watch_chromium.org, Aaron Boodman, dyu1, vrk (LEFT CHROMIUM), estade+watch_chromium.org, scherkus (not reviewing), Ilya Sherman, ihf+watch_chromium.org
Visibility:
Public.

Description

Add OVERRIDE to chrome/browser/ui/webui/. BUG=104314 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110920

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -104 lines) Patch
M chrome/browser/ui/webui/extension_icon_source.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/favicon_source.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/fileicon_source.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/hung_renderer_dialog.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/input_window_dialog_webui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/media/media_internals_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/foreign_session_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache_factory.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/thumbnail_source.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/advanced_options_handler.h View 1 chunk +9 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/options/autofill_options_handler.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/clear_browser_data_handler.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/cookies_view_handler.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/core_options_handler.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/options/font_settings_handler.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options/handler_options_handler.h View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/import_data_handler.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/language_options_handler.h View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/language_options_handler_common.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_handler.h View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/options_sync_setup_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/password_manager_handler.h View 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/options/personal_options_handler.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options/search_engine_manager_handler.h View 1 chunk +9 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/options/stop_syncing_handler.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/web_intents_settings_handler.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/screenshot_source.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/shared_resources_data_source.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/theme_source.h View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Avi (use Gerrit)
Just OVERRIDEs.
9 years, 1 month ago (2011-11-19 01:54:25 UTC) #1
James Hawkins
9 years, 1 month ago (2011-11-19 01:56:07 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698