Move SSL layer initialization into ChannelAuthenticator implementations.

remoting/protocol/jingle_datagram_connector.h

Index: remoting/protocol/jingle_datagram_connector.h
diff --git a/remoting/protocol/jingle_datagram_connector.h b/remoting/protocol/jingle_datagram_connector.h
index 621bbee1c0ba9e918e6bce1d2d36deb129474431..d29ee9332d37ca8bf75d44b8774c8ec91a0c807d 100644
--- a/remoting/protocol/jingle_datagram_connector.h
+++ b/remoting/protocol/jingle_datagram_connector.h
@@ -23,13 +23,8 @@ class JingleDatagramConnector : public JingleChannelConnector {
                          const Session::DatagramChannelCallback& callback);
   virtual ~JingleDatagramConnector();
 
-  // Starts connection process for the channel. |local_private_key| is
-  // owned by the caller, and must exist until this object is
-  // destroyed.
-  virtual void Connect(bool initiator,
-                       const std::string& local_cert,
-                       const std::string& remote_cert,
-                       crypto::RSAPrivateKey* local_private_key,
+  // JingleChannelConnector implementation.
+  virtual void Connect(ChannelAuthenticator* authenticator,

[Wez, 2011/11/22 22:29:48]

Does this make sense?  ChannelAuthenticator takes a StreamSocket, whereas this
is the datagram connector, which will create a datagram socket?

[Sergey Ulanov, 2011/11/23 01:23:42]

Currently JingleDatagramConnector doesn't use SSL anyway. When we get to
implementing it can be done in two ways:
 (1) Modify ChannelAuthenticator so that it knows how to authenticate datagram
channels.
 (2) Add DatagramChannelAuthenticator interface for datagram channels and add
CreateDatagramChannelAuthenticator() in Authenticator interface.

Because we are not using datagram channels right now, I don't think it is
necessary to solve this problem right now. Added TODO.

                        cricket::TransportChannel* raw_channel) OVERRIDE;
 
  private:
@@ -37,6 +32,8 @@ class JingleDatagramConnector : public JingleChannelConnector {
   std::string name_;
   Session::DatagramChannelCallback callback_;
 
+  scoped_ptr<ChannelAuthenticator> authenticator_;
+
   DISALLOW_COPY_AND_ASSIGN(JingleDatagramConnector);
 };