Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: remoting/protocol/pepper_stream_channel.h

Issue 8604001: Move SSL layer initialization into ChannelAuthenticator implementations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Simple->V1 Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/pepper_session.cc ('k') | remoting/protocol/pepper_stream_channel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/pepper_stream_channel.h
diff --git a/remoting/protocol/pepper_stream_channel.h b/remoting/protocol/pepper_stream_channel.h
index dbe206e4d34f86a9e7934becc8d2b98151783e41..5c17e4fc022e8f3f3ee449eca7977c79e3585f6a 100644
--- a/remoting/protocol/pepper_stream_channel.h
+++ b/remoting/protocol/pepper_stream_channel.h
@@ -37,7 +37,7 @@ class PepperStreamChannel : public PepperChannel,
// PepperChannel implementation.
virtual void Connect(pp::Instance* pp_instance,
const TransportConfig& transport_config,
- const std::string& remote_cert) OVERRIDE;
+ ChannelAuthenticator* authenticator) OVERRIDE;
virtual void AddRemoveCandidate(const cricket::Candidate& candidate) OVERRIDE;
virtual const std::string& name() const OVERRIDE;
virtual bool is_connected() const OVERRIDE;
@@ -49,12 +49,7 @@ class PepperStreamChannel : public PepperChannel,
private:
void OnP2PConnect(int result);
-
- bool EstablishSSLConnection();
- void OnSSLConnect(int result);
-
- void AuthenticateChannel();
- void OnAuthenticationDone(ChannelAuthenticator::Result result);
+ void OnAuthenticationDone(net::Error error, net::StreamSocket* socket);
void NotifyConnected(net::StreamSocket* socket);
void NotifyConnectFailed();
@@ -62,28 +57,18 @@ class PepperStreamChannel : public PepperChannel,
PepperSession* session_;
std::string name_;
Session::StreamChannelCallback callback_;
-
- std::string remote_cert_;
+ scoped_ptr<ChannelAuthenticator> authenticator_;
// We own |channel_| until it is connected. After that
- // SSLClientSocket owns it.
+ // |authenticator_| owns it.
scoped_ptr<PepperTransportSocketAdapter> owned_channel_;
PepperTransportSocketAdapter* channel_;
// Indicates that we've finished connecting.
bool connected_;
- scoped_ptr<net::StreamSocket> socket_;
- net::SSLClientSocket* ssl_client_socket_;
-
- // Used to verify the certificate received in SSLClientSocket.
- scoped_ptr<net::CertVerifier> cert_verifier_;
-
- scoped_ptr<ChannelAuthenticator> authenticator_;
-
- // Callback called by the TCP and SSL layers.
+ // Callback called by the TCP layer.
net::OldCompletionCallbackImpl<PepperStreamChannel> p2p_connect_callback_;
- net::OldCompletionCallbackImpl<PepperStreamChannel> ssl_connect_callback_;
DISALLOW_COPY_AND_ASSIGN(PepperStreamChannel);
};
« no previous file with comments | « remoting/protocol/pepper_session.cc ('k') | remoting/protocol/pepper_stream_channel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698