Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Unified Diff: remoting/protocol/jingle_stream_connector.h

Issue 8604001: Move SSL layer initialization into ChannelAuthenticator implementations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Simple->V1 Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/jingle_session.cc ('k') | remoting/protocol/jingle_stream_connector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/jingle_stream_connector.h
diff --git a/remoting/protocol/jingle_stream_connector.h b/remoting/protocol/jingle_stream_connector.h
index 27103deaebc2b3e4aeac03c3e1b7096cbc53e4bb..f37a69183c15eb5aba6b602564d43adff9aadbfa 100644
--- a/remoting/protocol/jingle_stream_connector.h
+++ b/remoting/protocol/jingle_stream_connector.h
@@ -41,24 +41,14 @@ class JingleStreamConnector : public JingleChannelConnector {
const Session::StreamChannelCallback& callback);
virtual ~JingleStreamConnector();
- // Starts connection process for the channel. |local_private_key| is
- // owned by the caller, and must exist until this object is
- // destroyed.
- virtual void Connect(bool initiator,
- const std::string& local_cert,
- const std::string& remote_cert,
- crypto::RSAPrivateKey* local_private_key,
+ // JingleChannelConnector implementation.
+ virtual void Connect(ChannelAuthenticator* authenticator,
cricket::TransportChannel* raw_channel) OVERRIDE;
private:
bool EstablishTCPConnection(net::Socket* socket);
void OnTCPConnect(int result);
-
- bool EstablishSSLConnection();
- void OnSSLConnect(int result);
-
- void AuthenticateChannel();
- void OnAuthenticationDone(ChannelAuthenticator::Result result);
+ void OnAuthenticationDone(net::Error error, net::StreamSocket* socket);
void NotifyDone(net::StreamSocket* socket);
void NotifyError();
@@ -67,23 +57,14 @@ class JingleStreamConnector : public JingleChannelConnector {
std::string name_;
Session::StreamChannelCallback callback_;
- bool initiator_;
- std::string local_cert_;
- std::string remote_cert_;
- crypto::RSAPrivateKey* local_private_key_;
-
cricket::TransportChannel* raw_channel_;
scoped_ptr<net::StreamSocket> tcp_socket_;
scoped_ptr<net::SSLSocket> socket_;
- // Used to verify the certificate received in SSLClientSocket.
- scoped_ptr<net::CertVerifier> cert_verifier_;
-
scoped_ptr<ChannelAuthenticator> authenticator_;
// Callback called by the TCP and SSL layers.
net::OldCompletionCallbackImpl<JingleStreamConnector> tcp_connect_callback_;
- net::OldCompletionCallbackImpl<JingleStreamConnector> ssl_connect_callback_;
DISALLOW_COPY_AND_ASSIGN(JingleStreamConnector);
};
« no previous file with comments | « remoting/protocol/jingle_session.cc ('k') | remoting/protocol/jingle_stream_connector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698