Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 8603013: base::Bind() conversion for MetricsService. (Closed)

Created:
9 years, 1 month ago by dcheng
Modified:
9 years, 1 month ago
CC:
chromium-reviews, Ilya Sherman
Visibility:
Public.

Description

base::Bind() conversion for MetricsService. BUG=none TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111047

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 4

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -42 lines) Patch
M chrome/browser/metrics/histogram_synchronizer.h View 1 2 3 5 chunks +18 lines, -14 lines 0 comments Download
M chrome/browser/metrics/histogram_synchronizer.cc View 1 2 3 7 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/metrics/metrics_service.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 2 3 4 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dcheng
9 years, 1 month ago (2011-11-21 08:10:28 UTC) #1
jar (doing other things)
isherman: PTAL I could have sworn I did a review for a CL on this ...
9 years, 1 month ago (2011-11-21 17:11:58 UTC) #2
Ilya Sherman
LGTM. I held off on updating these last few call sites in my CL because ...
9 years, 1 month ago (2011-11-21 21:09:46 UTC) #3
dcheng
http://codereview.chromium.org/8603013/diff/2002/chrome/browser/metrics/histogram_synchronizer.h File chrome/browser/metrics/histogram_synchronizer.h (right): http://codereview.chromium.org/8603013/diff/2002/chrome/browser/metrics/histogram_synchronizer.h#newcode82 chrome/browser/metrics/histogram_synchronizer.h:82: int wait_time); On 2011/11/21 21:09:46, Ilya Sherman wrote: > ...
9 years, 1 month ago (2011-11-21 22:06:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/8603013/9001
9 years, 1 month ago (2011-11-21 22:06:15 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-22 00:08:41 UTC) #6
Change committed as 111047

Powered by Google App Engine
This is Rietveld 408576698