content/browser/plugin_service.cc - Issue 8603012: Fix race in PluginDataRemoverImpl going away while it's still being used on the IO thread...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/plugin_service.cc

Issue 8603012: Fix race in PluginDataRemoverImpl going away while it's still being used on the IO thread... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/plugin_data_remover_impl.h ('K') | « content/browser/plugin_data_remover_impl.cc ('k') | content/browser/plugin_service_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/plugin_service.cc

===================================================================

--- content/browser/plugin_service.cc (revision 110846)

+++ content/browser/plugin_service.cc (working copy)

@@ -332,6 +332,7 @@

const GURL& page_url,

const std::string& mime_type,

PluginProcessHost::Client* client) {

+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

DCHECK(!ContainsKey(pending_plugin_clients_, client));

pending_plugin_clients_.insert(client);

« content/browser/plugin_data_remover_impl.h ('K') | « content/browser/plugin_data_remover_impl.cc ('k') | content/browser/plugin_service_browsertest.cc » ('j') | no next file with comments »