Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 8603010: content settings bubble using new ui/views/bubble api. (Closed)

Created:
9 years, 1 month ago by alicet1
Modified:
9 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

content settings bubble using new ui/views/bubble api. BUG=98323 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111085

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -125 lines) Patch
M chrome/browser/ui/views/content_setting_bubble_contents.h View 1 2 5 chunks +16 lines, -18 lines 0 comments Download
M chrome/browser/ui/views/content_setting_bubble_contents.cc View 1 2 4 chunks +54 lines, -58 lines 0 comments Download
M chrome/browser/ui/views/location_bar/content_setting_image_view.h View 1 2 4 chunks +3 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/location_bar/content_setting_image_view.cc View 1 2 4 chunks +12 lines, -37 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
alicet1
9 years, 1 month ago (2011-11-19 19:42:54 UTC) #1
msw
LGTM
9 years, 1 month ago (2011-11-19 23:41:10 UTC) #2
alicet1
adding ben to take a look, thanks!
9 years, 1 month ago (2011-11-20 00:52:47 UTC) #3
Ben Goodger (Google)
lgtm
9 years, 1 month ago (2011-11-21 16:50:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alicet@chromium.org/8603010/2005
9 years, 1 month ago (2011-11-21 23:02:12 UTC) #5
commit-bot: I haz the power
Try job failure for 8603010-2005 (retry) on mac_rel for step "ui_tests" (clobber build). It's a ...
9 years, 1 month ago (2011-11-22 00:56:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alicet@chromium.org/8603010/2005
9 years, 1 month ago (2011-11-22 01:01:25 UTC) #7
commit-bot: I haz the power
9 years, 1 month ago (2011-11-22 02:45:08 UTC) #8
Change committed as 111085

Powered by Google App Engine
This is Rietveld 408576698