Issue 8603007: More base::Bind migrations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8603007: More base::Bind migrations. (Closed)

Created:
9 years, 1 month ago by csilv

Modified:
9 years, 1 month ago

Reviewers:
James Hawkins

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

More base::Bind migrations. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111241

Patch Set 2 : code review tweak, rebase #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -7 lines)			Patch
M	chrome/browser/password_manager/password_store_win.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/user_style_sheet_watcher.cc	View	1	3 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/default_plugin/plugin_install_job_monitor.cc	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

LGTM with nit. http://codereview.chromium.org/8603007/diff/1/chrome/default_plugin/plugin_install_job_monitor.cc File chrome/default_plugin/plugin_install_job_monitor.cc (right): http://codereview.chromium.org/8603007/diff/1/chrome/default_plugin/plugin_install_job_monitor.cc#newcode45 chrome/default_plugin/plugin_install_job_monitor.cc:45: this->message_loop()->PostTask(FROM_HERE, Same-col.

9 years, 1 month ago (2011-11-19 03:29:16 UTC) #2

csilv

9 years, 1 month ago (2011-11-22 19:42:44 UTC) #3

http://codereview.chromium.org/8603007/diff/1/chrome/default_plugin/plugin_in...
File chrome/default_plugin/plugin_install_job_monitor.cc (right):

http://codereview.chromium.org/8603007/diff/1/chrome/default_plugin/plugin_in...
chrome/default_plugin/plugin_install_job_monitor.cc:45:
this->message_loop()->PostTask(FROM_HERE,
On 2011/11/19 03:29:16, James Hawkins wrote:
> Same-col.

Done.

Expand Messages | Collapse Messages

Issue 8603007: More base::Bind migrations. (Closed)

Description

Patch Set 1 #

Patch Set 2 : code review tweak, rebase #

Messages