Issue 8603006: Add OVERRIDE to chrome/browser/ui/cocoa/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8603006: Add OVERRIDE to chrome/browser/ui/cocoa/. (Closed)

Created:
9 years, 1 month ago by Avi (use Gerrit)

Modified:
9 years, 1 month ago

Reviewers:
Nico

CC:
chromium-reviews, asanka, James Su, yoshiki+watch_chromium.org, Randy Smith (Not in Mondays), Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add OVERRIDE to chrome/browser/ui/cocoa/. BUG=104314 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110916

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+227 lines, -215 lines)			Patch
M	chrome/browser/ui/cocoa/about_ipc_dialog.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_unittest.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_cocoa.h	View	3 chunks	+72 lines, -69 lines	0 comments	Download
M	chrome/browser/ui/cocoa/cocoa_profile_test.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/command_observer_bridge.h	View	3 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/constrained_window_mac.h	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/download/background_theme.h	View	1 chunk	+13 lines, -12 lines	0 comments	Download
M	chrome/browser/ui/cocoa/download/download_item_mac.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/download/download_shelf_mac.h	View	2 chunks	+7 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/cocoa/find_bar/find_bar_bridge.h	View	2 chunks	+21 lines, -19 lines	0 comments	Download
M	chrome/browser/ui/cocoa/history_menu_bridge.h	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/cocoa/js_modal_dialog_cocoa.h	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/bubble_decoration.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/content_setting_decoration.h	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.h	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/image_decoration.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/keyword_hint_decoration.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h	View	2 chunks	+13 lines, -12 lines	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/location_icon_decoration.h	View	1 chunk	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/page_action_decoration.h	View	3 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/star_decoration.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/cocoa/notifications/balloon_view_bridge.h	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/cocoa/repost_form_warning_mac.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/status_icons/status_icon_mac.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.h	View	2 chunks	+12 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/cocoa/task_manager_mac.h	View	1 chunk	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Keep 'em coming :-)

Expand Messages | Collapse Messages