Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 8603004: Update sizes to account for http://crrev.com/110076 and others. (Closed)

Created:
9 years, 1 month ago by kerz_chromium
Modified:
9 years, 1 month ago
Reviewers:
cmp
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/perf_expectations/perf_expectations.json View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kerz_chromium
9 years, 1 month ago (2011-11-19 01:39:10 UTC) #1
cmp
lgtm
9 years, 1 month ago (2011-11-21 17:47:55 UTC) #2
cmp
Remember that by including URLs that have 'rev=-1' in them, the URLs will always show ...
9 years, 1 month ago (2011-11-21 17:49:02 UTC) #3
kerz_chromium
On 2011/11/21 17:49:02, cmp wrote: > Remember that by including URLs that have 'rev=-1' in ...
9 years, 1 month ago (2011-11-21 17:52:40 UTC) #4
cmp
9 years, 1 month ago (2011-11-21 17:57:57 UTC) #5
On 2011/11/21 17:52:40, kerz_chromium wrote:
> Sorry, had changed them in my buffer after, but not here.

No problem.

> Would be nice if the links from the waterfall were linked in time
> to the results somehow.

I agree, I think it's necessary.  Expect that to happen automatically at some
point.  If you want to get involved with the code, I can show you exactly what
to change and how to test, it should be easy, just needs cycles.

Powered by Google App Engine
This is Rietveld 408576698