Issue 8602012: base::Bind: Convert render_view_impl.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8602012: base::Bind: Convert render_view_impl.cc. (Closed)

Created:
9 years, 1 month ago by James Hawkins

Modified:
9 years, 1 month ago

Reviewers:
csilv

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

base::Bind: Convert render_view_impl.cc. BUG=none TEST=none R=csilv@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110810

Patch Set 2 : Review fix. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -11 lines)			Patch
M	content/renderer/render_view_impl.cc	View	1	3 chunks	+6 lines, -3 lines	0 comments	Download
M	webkit/glue/alt_error_page_resource_fetcher.h	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	webkit/glue/alt_error_page_resource_fetcher.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

csilv

lgtm http://codereview.chromium.org/8602012/diff/1/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): http://codereview.chromium.org/8602012/diff/1/content/renderer/render_view_impl.cc#newcode12 content/renderer/render_view_impl.cc:12: #include "base/bind.h" add bind/bind_helpers.h

9 years, 1 month ago (2011-11-19 00:52:43 UTC) #2

James Hawkins

9 years, 1 month ago (2011-11-19 01:12:59 UTC) #3

Going off the previous tryjobs since I merely added an include.

http://codereview.chromium.org/8602012/diff/1/content/renderer/render_view_im...
File content/renderer/render_view_impl.cc (right):

http://codereview.chromium.org/8602012/diff/1/content/renderer/render_view_im...
content/renderer/render_view_impl.cc:12: #include "base/bind.h"
On 2011/11/19 00:52:43, csilv wrote:
> add bind/bind_helpers.h

Done.

Expand Messages | Collapse Messages

Issue 8602012: base::Bind: Convert render_view_impl.cc. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Review fix. #

Messages