Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 8602009: CrOS: Fix file_watchers_ DCHECK in SelectFileDialogExtensionBrowserTest (Closed)

Created:
9 years, 1 month ago by James Cook
Modified:
9 years, 1 month ago
Reviewers:
rginda, Dmitry Zvorygin
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org
Visibility:
Public.

Description

CrOS: Fix file_watchers_ DCHECK in SelectFileDialogExtensionBrowserTest The CrOS file picker closes the dialog immediately, without running the page unload handler. This meant we were leaking file watcher objects, causing a DCHECK in SelectFileDialogExtensionBrowserTest. Fixed by calling it manually when needed. Also, we need to clean up the current directory's watcher, because we don't have a directory-change event in the unload handler that we can use to look up the directory path. BUG=104692, 103491 TEST=browser_tests, also verify you can open a file with control-O Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110789

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -10 lines) Patch
M chrome/browser/resources/file_manager/js/file_manager.js View 6 chunks +41 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
James Cook
Guys, please take a look. This works on my linux_chromeos build for manually picking a ...
9 years, 1 month ago (2011-11-18 22:34:03 UTC) #1
Dmitry Zvorygin
On 2011/11/18 22:34:03, James Cook (Chromium) wrote: > Guys, please take a look. This works ...
9 years, 1 month ago (2011-11-18 23:14:04 UTC) #2
rginda
9 years, 1 month ago (2011-11-18 23:39:55 UTC) #3
LGTM too

Powered by Google App Engine
This is Rietveld 408576698