Panels: Disable auto-resize if initial size is specified during creation.

chrome/browser/ui/panels/panel_manager.cc

Index: chrome/browser/ui/panels/panel_manager.cc
diff --git a/chrome/browser/ui/panels/panel_manager.cc b/chrome/browser/ui/panels/panel_manager.cc
index f9afd8c6df36e38022ba2655d6ec0cd278b8e1f8..3b7bf60359af13495c3e6a613ffea42a9044dcad 100644
--- a/chrome/browser/ui/panels/panel_manager.cc
+++ b/chrome/browser/ui/panels/panel_manager.cc
@@ -100,10 +100,13 @@ Panel* PanelManager::CreatePanel(Browser* browser) {
   int width = browser->override_bounds().width();
   int height = browser->override_bounds().height();
 
-  if (width == 0 && height == 0) {
+  // Auto resizable is enabled only if no initial size is provided.
+  bool auto_resize = (width == 0 && height == 0);
+
+  if (width == 0)
     width = kPanelDefaultWidth;
+  if (height == 0)
     height = kPanelDefaultHeight;
-  }
 
   int max_panel_width = GetMaxPanelWidth();
   int max_panel_height = GetMaxPanelHeight();
@@ -124,6 +127,8 @@ Panel* PanelManager::CreatePanel(Browser* browser) {
   // Now create the panel with the computed bounds.
   Panel* panel = new Panel(browser, gfx::Rect(x, y, width, height));

[Dmitry Titov, 2011/11/18 23:48:27]

Does it still make sense to pass bounds into constructor if we also explicitly
set min and max here?

Maybe we should be passing explicit min, max, default sizes into constructor and
also an 'autoresize' bit?
Alternatively, we could not pass any sizes to constructor and initialize
min=max=default=0 and then rely on explicit setters.
Either one seems better then pass one size and then set 2 others.

[jennb, 2011/11/18 23:54:01]

It still makes sense as native panel needs bounds when its constructed. The
others are after-thoughts that could be set or not set. Putting them in the ctor
would mean they are all required.

   panel->SetMaxSize(gfx::Size(max_panel_width, max_panel_height));
+  panel->SetMinSize(gfx::Size(kPanelMinWidth, kPanelMinHeight));
+  panel->SetAutoResizable(auto_resize);
   panels_.push_back(panel);
 
   content::NotificationService::current()->Notify(