Panels: Disable auto-resize if initial size is specified during creation.

chrome/browser/ui/panels/panel_manager.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel_manager.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/logging.h"
@@ skipping 82 matching lines @@
   AdjustWorkAreaForAutoHidingDesktopBars();
 
   Rearrange(panels_.begin(), StartingRightPosition());
 }
 
 Panel* PanelManager::CreatePanel(Browser* browser) {
   // Adjust the width and height to fit into our constraint.
   int width = browser->override_bounds().width();
   int height = browser->override_bounds().height();
 
-  if (width == 0 && height == 0) {
+  // Auto resizable is enabled only if no initial size is provided.
+  bool auto_resize = !(width || height);

[Dmitry Titov, 2011/11/18 23:00:34]

I think the coding style actually prefers this style for pointers (do not
compare with NULL) but does not encourage that for sizes, times or other
non-pointer integral types. 

From readability point, it makes it less spottable that size has a sentinel
value that means something different then size (in itself an unfortunate idea,
but at least it is good when it is explicit). 

In next 2 lines you compare with 0 explicitly. What should it be?

[jianli, 2011/11/18 23:03:32]

I find it more readable if we say "width = 0 && height == 0".

[jennb, 2011/11/18 23:26:00]

Done.

+
+  if (width == 0)
     width = kPanelDefaultWidth;
+  if (height == 0)
     height = kPanelDefaultHeight;
-  }
 
   int max_panel_width = GetMaxPanelWidth();
   int max_panel_height = GetMaxPanelHeight();
 
   if (width < kPanelMinWidth)
     width = kPanelMinWidth;
   else if (width > max_panel_width)
     width = max_panel_width;
 
   if (height < kPanelMinHeight)
     height = kPanelMinHeight;
   else if (height > max_panel_height)
     height = max_panel_height;
 
   int y = adjusted_work_area_.bottom() - height;
   int x = GetRightMostAvailablePosition() - width;
 
   // Now create the panel with the computed bounds.
   Panel* panel = new Panel(browser, gfx::Rect(x, y, width, height));
   panel->SetMaxSize(gfx::Size(max_panel_width, max_panel_height));
+  panel->SetMinSize(gfx::Size(kPanelMinWidth, kPanelMinHeight));
+  panel->SetAutoResizable(auto_resize);
   panels_.push_back(panel);
 
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_PANEL_ADDED,
       content::Source<Panel>(panel),
       content::NotificationService::NoDetails());
 
   return panel;
 }
 
@@ skipping 478 matching lines @@
 
   // Start from the bottom to avoid reshuffling.
   for (Panels::reverse_iterator iter = panels_copy.rbegin();
        iter != panels_copy.rend(); ++iter)
     (*iter)->Close();
 }
 
 bool PanelManager::is_dragging_panel() const {
   return dragging_panel_index_ != kInvalidPanelIndex;
 }