Issue 8602006: chromeos: Remove unused code from CryptohomeLibrary.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8602006: chromeos: Remove unused code from CryptohomeLibrary. (Closed)

Created:
9 years, 1 month ago by satorux1

Modified:
9 years, 1 month ago

Reviewers:
stevenjb

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

chromeos: Remove unused code from CryptohomeLibrary. BUG=chromium-os:16552 TEST=chrome and tests build Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111109

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -152 lines)			Patch
M	chrome/browser/chromeos/cros/cryptohome_library.h	View	6 chunks	+0 lines, -34 lines	0 comments	Download
M	chrome/browser/chromeos/cros/cryptohome_library.cc	View	15 chunks	+0 lines, -101 lines	0 comments	Download
M	chrome/browser/chromeos/cros/mock_cryptohome_library.h	View	2 chunks	+0 lines, -14 lines	0 comments	Download
M	chrome/browser/chromeos/cros/mock_cryptohome_library.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

stevenjb

This seems fine to me, but I would have someone familiar with the cryptohome code ...

9 years, 1 month ago (2011-11-18 23:20:13 UTC) #2

satorux1

These methods are old and unused. The owner is unclear, so I think we can ...

9 years, 1 month ago (2011-11-19 00:44:04 UTC) #3

OK, lgtm.