Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1586)

Unified Diff: chrome/browser/prerender/prerender_manager.cc

Issue 8602005: Adding histograms for better Omnibox prerender performance tracking. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autocomplete/network_action_predictor.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_manager.cc
diff --git a/chrome/browser/prerender/prerender_manager.cc b/chrome/browser/prerender/prerender_manager.cc
index 18093a932c96f1e72d12bfa15f0c789a2a624cd6..98f161d1b43d56f611a0f4ba1aab3f648326e528 100644
--- a/chrome/browser/prerender/prerender_manager.cc
+++ b/chrome/browser/prerender/prerender_manager.cc
@@ -357,6 +357,8 @@ bool PrerenderManager::AddPrerenderFromOmnibox(
NOTREACHED();
break;
};
+ UMA_HISTOGRAM_COUNTS("Prerender.OmniboxPrerenderCount_" +
+ prerender::GetOmniboxHistogramSuffix(), 1);
return AddPrerender(origin, std::make_pair(-1, -1), url, GURL(),
session_storage_namespace);
@@ -646,6 +648,13 @@ bool PrerenderManager::MaybeUsePrerenderedPage(TabContents* tab_contents,
histograms_->RecordPerSessionCount(++prerenders_per_session_count_);
prerender_contents->set_final_status(FINAL_STATUS_USED);
+ if (prerender_contents->origin() == ORIGIN_OMNIBOX_ORIGINAL ||
+ prerender_contents->origin() == ORIGIN_OMNIBOX_CONSERVATIVE ||
+ prerender_contents->origin() == ORIGIN_OMNIBOX_EXACT) {
+ UMA_HISTOGRAM_COUNTS("Prerender.OmniboxNavigationsUsedPrerenderCount_" +
tburkard 2011/11/21 23:45:39 Wouldn't this fit nicer into prerender_histograms
+ prerender::GetOmniboxHistogramSuffix(), 1);
+ }
+
new_render_view_host->Send(
new ChromeViewMsg_SetIsPrerendering(new_render_view_host->routing_id(),
false));
« no previous file with comments | « chrome/browser/autocomplete/network_action_predictor.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698