Fix code generation issue with new factory syntax.

runtime/vm/class_finalizer.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/class_finalizer.h"
 
 #include "vm/flags.h"
 #include "vm/heap.h"
 #include "vm/isolate.h"
 #include "vm/longjump.h"
@@ skipping 396 matching lines @@
     expected_type_extends = expected_extends_array.TypeAt(i);
     actual_type_extends = actual_extends_array.TypeAt(i);
     if (!expected_type_name.Equals(actual_type_name) ||
         !expected_type_extends.Equals(actual_type_extends)) {
       mismatch = true;
     }
   }
   if (mismatch) {
     const String& interface_name = String::Handle(interface.Name());
     const String& factory_name = String::Handle(factory_class.Name());
+    // TODO(regis): Report the filename and position as well.
     ReportError("mismatch in number or names of type parameters between "
                 "factory clause of interface '%s' and actual factory "
                 "class '%s'.\n",
                 interface_name.ToCString(),
                 factory_name.ToCString());
   }
 }
 
 
 // TODO(regis): Now that we do not resolve type parameters anymore, we could
@@ skipping 293 matching lines @@
           // list of the enclosing class.
           // See bug 5408808.
           const Class& enclosing_class = Class::Handle(function.owner());
           function.set_signature_class(enclosing_class);
           ReportWarning("Warning: factory method '%s' should declare a list of "
                         "%d type parameter%s.\n",
                         function_name.ToCString(),
                         type_class.NumTypeParameters(),
                         type_class.NumTypeParameters() > 1 ? "s" : "");
         } else {
+          // TODO(regis): Report the filename and position as well.
           ReportError("factory method '%s' must declare %d type parameter%s.\n",
                       function_name.ToCString(),
                       type_class.NumTypeParameters(),
                       type_class.NumTypeParameters() > 1 ? "s" : "");
         }
       }
     } else {
       type = ResolveType(cls, type);
       function.set_result_type(type);
     }
@@ skipping 534 matching lines @@
   va_end(args);
   if (FLAG_warning_as_error) {
     isolate->long_jump_base()->Jump(1, msg_buffer);
     UNREACHABLE();
   } else {
     OS::Print(msg_buffer);
   }
 }
 
 }  // namespace dart