Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Side by Side Diff: runtime/lib/array.dart

Issue 8602004: Fix code generation issue with new factory syntax. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/lib/growable_array.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 class ListFactory<T> { 5 class ListFactory {
6 6
7 factory List.from(Iterable<T> other) { 7 factory List<T>.from(Iterable<T> other) {
8 GrowableObjectArray<T> list = new GrowableObjectArray<T>(); 8 GrowableObjectArray<T> list = new GrowableObjectArray<T>();
9 for (final e in other) { 9 for (final e in other) {
10 list.add(e); 10 list.add(e);
11 } 11 }
12 return list; 12 return list;
13 } 13 }
14 14
15 factory List([int length = null]) { 15 factory List<T>([int length = null]) {
16 if (length === null) { 16 if (length === null) {
17 return new GrowableObjectArray<T>(); 17 return new GrowableObjectArray<T>();
18 } else { 18 } else {
19 return new ObjectArray<T>(length); 19 return new ObjectArray<T>(length);
20 } 20 }
21 } 21 }
22 } 22 }
23 23
24 // TODO(srdjan): Use shared array implementation. 24 // TODO(srdjan): Use shared array implementation.
25 class ObjectArray<T> implements List<T> { 25 class ObjectArray<T> implements List<T> {
26 26
27 factory ObjectArray(int length) native "ObjectArray_allocate"; 27 factory ObjectArray<T>(int length) native "ObjectArray_allocate";
28 28
29 T operator [](int index) native "ObjectArray_getIndexed"; 29 T operator [](int index) native "ObjectArray_getIndexed";
30 30
31 void operator []=(int index, T value) native "ObjectArray_setIndexed"; 31 void operator []=(int index, T value) native "ObjectArray_setIndexed";
32 32
33 String toString() { 33 String toString() {
34 return Arrays.asString(this); 34 return Arrays.asString(this);
35 } 35 }
36 36
37 int get length() native "ObjectArray_getLength"; 37 int get length() native "ObjectArray_getLength";
(...skipping 257 matching lines...) Expand 10 before | Expand all | Expand 10 after
295 if (!hasNext()) { 295 if (!hasNext()) {
296 throw const NoMoreElementsException(); 296 throw const NoMoreElementsException();
297 } 297 }
298 return _array[_pos++]; 298 return _array[_pos++];
299 } 299 }
300 300
301 final List<T> _array; 301 final List<T> _array;
302 final int _length; // Cache array length for faster access. 302 final int _length; // Cache array length for faster access.
303 int _pos; 303 int _pos;
304 } 304 }
OLDNEW
« no previous file with comments | « no previous file | runtime/lib/growable_array.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698