Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: webkit/glue/resource_loader_bridge.h

Issue 8602002: Move some webkit_glue embedder functions into WebKitPlatformSupport virtual methods (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: copyright year Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/compositor/test/compositor_test_support.cc ('k') | webkit/glue/webkit_glue.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/resource_loader_bridge.h
diff --git a/webkit/glue/resource_loader_bridge.h b/webkit/glue/resource_loader_bridge.h
index 6711039652ad869bb9584f6b524f2e50f963c0b1..da0a36e716607c916ea6eca00268c9e974c4560a 100644
--- a/webkit/glue/resource_loader_bridge.h
+++ b/webkit/glue/resource_loader_bridge.h
@@ -4,8 +4,7 @@
//
// The intent of this file is to provide a type-neutral abstraction between
// Chrome and WebKit for resource loading. This pure-virtual interface is
-// implemented by the embedder, which also provides a factory method Create
-// to instantiate this object.
+// implemented by the embedder.
//
// One of these objects will be created by WebKit for each request. WebKit
// will own the pointer to the bridge, and will delete it when the request is
@@ -197,7 +196,8 @@ struct ResourceResponseInfo {
class ResourceLoaderBridge {
public:
- // Structure used when calling ResourceLoaderBridge::Create().
+ // Structure used when calling
+ // WebKitPlatformSupportImpl::CreateResourceLoader().
struct RequestInfo {
RequestInfo();
~RequestInfo();
@@ -329,16 +329,10 @@ class ResourceLoaderBridge {
const base::Time& completion_time) = 0;
};
- // use Create() for construction, but anybody can delete at any time,
- // INCLUDING during processing of callbacks.
+ // use WebKitPlatformSupportImpl::CreateResourceLoader() for construction, but
+ // anybody can delete at any time, INCLUDING during processing of callbacks.
virtual ~ResourceLoaderBridge();
- // Call this method to make a new instance.
- //
- // For HTTP(S) POST requests, the AppendDataToUpload and AppendFileToUpload
- // methods may be called to construct the body of the request.
- static ResourceLoaderBridge* Create(const RequestInfo& request_info);
-
// Call this method before calling Start() to append a chunk of binary data
// to the request body. May only be used with HTTP(S) POST requests.
virtual void AppendDataToUpload(const char* data, int data_len) = 0;
@@ -394,7 +388,10 @@ class ResourceLoaderBridge {
virtual void UpdateRoutingId(int new_routing_id) = 0;
protected:
- // construction must go through Create()
+ // Construction must go through
+ // WebKitPlatformSupportImpl::CreateResourceLoader()
+ // For HTTP(S) POST requests, the AppendDataToUpload and AppendFileToUpload
+ // methods may be called to construct the body of the request.
ResourceLoaderBridge();
private:
« no previous file with comments | « ui/gfx/compositor/test/compositor_test_support.cc ('k') | webkit/glue/webkit_glue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698