Move some webkit_glue embedder functions into WebKitPlatformSupport virtual methods

content/common/content_webkitplatformsupport_impl.h

Index: content/common/content_webkitplatformsupport_impl.h
diff --git a/content/common/content_webkitplatformsupport_impl.h b/content/common/content_webkitplatformsupport_impl.h
new file mode 100644
index 0000000000000000000000000000000000000000..7fd970718f6e7e190d954377c1043cdb4a269adc
--- /dev/null
+++ b/content/common/content_webkitplatformsupport_impl.h
@@ -0,0 +1,34 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_COMMON_CONTENT_WEBKITPLATFORMSUPPORT_IMPL_H_
+#define CONTENT_COMMON_CONTENT_WEBKITPLATFORMSUPPORT_IMPL_H_
+#pragma once
+
+#include "base/compiler_specific.h"
+#include "content/common/content_export.h"
+#include "webkit/glue/webkitplatformsupport_impl.h"
+
+// This is a specialization of WebKitPlatformSupportImpl that implements the
+// embedder functions in terms of ContentClient.
+class CONTENT_EXPORT ContentWebKitPlatformSupportImpl

[jam, 2011/11/19 23:13:46]

we try to avoid putting Content in class names, since new code should already be
in the content namespace. so content::WebKitPlatformSupporImpl?

[piman, 2011/11/21 22:05:04]

Done.

+    : NON_EXPORTED_BASE(public webkit_glue::WebKitPlatformSupportImpl) {
+ public:
+  ContentWebKitPlatformSupportImpl();
+  virtual ~ContentWebKitPlatformSupportImpl();
+
+  virtual string16 GetLocalizedString(int message_id) OVERRIDE;
+  virtual base::StringPiece GetDataResource(int resource_id) OVERRIDE;
+  virtual void GetPlugins(bool refresh,
+                          std::vector<webkit::WebPluginInfo>* plugins) OVERRIDE;
+  virtual webkit_glue::ResourceLoaderBridge* CreateResourceLoader(
+      const webkit_glue::ResourceLoaderBridge::RequestInfo& request_info)
+      OVERRIDE;
+  virtual webkit_glue::WebSocketStreamHandleBridge* CreateWebSocketBridge(
+      WebKit::WebSocketStreamHandle* handle,
+      webkit_glue::WebSocketStreamHandleDelegate* delegate) OVERRIDE;
+};
+
+#endif  // CONTENT_COMMON_CONTENT_WEBKITPLATFORMSUPPORT_IMPL_H_
+