chrome/browser/idbbindingutilities_browsertest.cc - Issue 8602002: Move some webkit_glue embedder functions into WebKitPlatformSupport virtual methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/idbbindingutilities_browsertest.cc

Issue 8602002: Move some webkit_glue embedder functions into WebKitPlatformSupport virtual methods (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: style Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/in_process_webkit/browser_webkitplatformsupport_impl.h » ('j') | content/common/content_webkitplatformsupport_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/idbbindingutilities_browsertest.cc

diff --git a/chrome/browser/idbbindingutilities_browsertest.cc b/chrome/browser/idbbindingutilities_browsertest.cc

index d8bb0e2828a34b4798fc1aaee15c4505fce33fcd..9d78f5dddee05b68028e21e08fe44d6464d79d99 100644

--- a/chrome/browser/idbbindingutilities_browsertest.cc

+++ b/chrome/browser/idbbindingutilities_browsertest.cc

@@ -8,6 +8,7 @@

#include "chrome/test/base/ui_test_utils.h"

#include "content/browser/renderer_host/resource_dispatcher_host.h"

#include "content/browser/utility_process_host.h"

+#include "content/common/content_webkitplatformsupport_impl.h"

jam 2011/11/19 23:13:46 nit: files in chrome should only be including (new

piman 2011/11/21 22:05:04 Good, problem fixes self.

#include "content/common/indexed_db_key.h"

#include "content/common/utility_messages.h"

#include "content/public/common/serialized_script_value.h"

@@ -17,7 +18,6 @@

#include "third_party/WebKit/Source/WebKit/chromium/public/WebSerializedScriptValue.h"

#include "webkit/glue/idb_bindings.h"

#include "webkit/glue/web_io_operators.h"

-#include "webkit/glue/webkitplatformsupport_impl.h"

using content::BrowserThread;

using WebKit::WebSerializedScriptValue;

@@ -38,7 +38,7 @@ class ScopedShutdownWebKit {

// Sanity test, check the function call directly outside the sandbox.

TEST(IDBKeyPathWithoutSandbox, Value) {

- webkit_glue::WebKitPlatformSupportImpl webkit_platform_support;

+ ContentWebKitPlatformSupportImpl webkit_platform_support;

WebKit::initialize(&webkit_platform_support);

ScopedShutdownWebKit shutdown_webkit;