Move some webkit_glue embedder functions into WebKitPlatformSupport virtual methods

webkit/glue/resource_loader_bridge.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // The intent of this file is to provide a type-neutral abstraction between
 // Chrome and WebKit for resource loading. This pure-virtual interface is
-// implemented by the embedder, which also provides a factory method Create
-// to instantiate this object.
+// implemented by the embedder.
 //
 // One of these objects will be created by WebKit for each request. WebKit
 // will own the pointer to the bridge, and will delete it when the request is
 // no longer needed.
 //
 // In turn, the bridge's owner on the WebKit end will implement the Peer
 // interface, which we will use to communicate notifications back.
 
 #ifndef WEBKIT_GLUE_RESOURCE_LOADER_BRIDGE_H_
 #define WEBKIT_GLUE_RESOURCE_LOADER_BRIDGE_H_
@@ skipping 171 matching lines @@
   // transparent proxy). The proxy could be any type of proxy, HTTP or SOCKS.
   // Note: we cannot tell if a transparent proxy may have been involved.
   bool was_fetched_via_proxy;
 
   // Remote address of the socket which fetched this resource.
   net::HostPortPair socket_address;
 };
 
 class ResourceLoaderBridge {
  public:
-  // Structure used when calling ResourceLoaderBridge::Create().
+  // Structure used when calling
+  // WebKitPlatformSupportImpl::CreateResourceLoader().
   struct RequestInfo {
     RequestInfo();
     ~RequestInfo();
 
     // HTTP-style method name (e.g., "GET" or "POST").
     std::string method;
 
     // Absolute URL encoded in ASCII per the rules of RFC-2396.
     GURL url;
 
@@ skipping 111 matching lines @@
     // cache. This method may be called zero or one times.
     virtual void OnReceivedCachedMetadata(const char* data, int len) { }
 
     // Called when the response is complete.  This method signals completion of
     // the resource load.ff
     virtual void OnCompletedRequest(const net::URLRequestStatus& status,
                                     const std::string& security_info,
                                     const base::Time& completion_time) = 0;
   };
 
-  // use Create() for construction, but anybody can delete at any time,
-  // INCLUDING during processing of callbacks.
+  // use WebKitPlatformSupportImpl::CreateResourceLoader() for construction, but
+  // anybody can delete at any time, INCLUDING during processing of callbacks.
   virtual ~ResourceLoaderBridge();
 
-  // Call this method to make a new instance.
-  //
-  // For HTTP(S) POST requests, the AppendDataToUpload and AppendFileToUpload
-  // methods may be called to construct the body of the request.
-  static ResourceLoaderBridge* Create(const RequestInfo& request_info);
-
   // Call this method before calling Start() to append a chunk of binary data
   // to the request body.  May only be used with HTTP(S) POST requests.
   virtual void AppendDataToUpload(const char* data, int data_len) = 0;
 
   // Call this method before calling Start() to append the contents of a file
   // to the request body.  May only be used with HTTP(S) POST requests.
   void AppendFileToUpload(const FilePath& file_path) {
     AppendFileRangeToUpload(file_path, 0, kuint64max, base::Time());
   }
 
@@ skipping 35 matching lines @@
   // use this if you really need it!  There is also no way for the caller to
   // interrupt this method.  Errors are reported via the status field of the
   // response parameter.
   virtual void SyncLoad(SyncLoadResponse* response) = 0;
 
   // When loader is transferred from one page to another, the IPC routing id
   // can change (they are associated with pages).
   virtual void UpdateRoutingId(int new_routing_id) = 0;
 
  protected:
-  // construction must go through Create()
+  // Construction must go through
+  // WebKitPlatformSupportImpl::CreateResourceLoader()
+  // For HTTP(S) POST requests, the AppendDataToUpload and AppendFileToUpload
+  // methods may be called to construct the body of the request.
   ResourceLoaderBridge();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ResourceLoaderBridge);
 };
 
 }  // namespace webkit_glue
 
 #endif  // WEBKIT_GLUE_RESOURCE_LOADER_BRIDGE_H_