Modify session restore test to set restore setting via UI and verify UI settings using web driver.

Modify session restore test to set restore setting via UI and verify UI settings using web driver.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111295

[kkania, 2011-11-22 20:42:45]

lgtm

http://codereview.chromium.org/8601009/diff/2001/functional/prefs.py
File functional/prefs.py (right):

http://codereview.chromium.org/8601009/diff/2001/functional/prefs.py#newcode32
functional/prefs.py:32: url1 = 'http://www.google.com/'
there's no reason to use public URLs for this test; it would be great to change
them; up to you

http://codereview.chromium.org/8601009/diff/2001/functional/prefs.py#newcode38
functional/prefs.py:38: restore = driver.find_element_by_xpath(
I think a good convention to start is appending '_elem' on to the end for all
WebElements. change to restore_elem

[vivianz, 2011-11-22 22:29:43]

http://codereview.chromium.org/8601009/diff/2001/functional/prefs.py
File functional/prefs.py (right):

http://codereview.chromium.org/8601009/diff/2001/functional/prefs.py#newcode32
functional/prefs.py:32: url1 = 'http://www.google.com/'
On 2011/11/22 20:42:46, kkania wrote:
> there's no reason to use public URLs for this test; it would be great to
change
> them; up to you
make sense, but will leave as is this time, since all other prefs test still use
these public urls. We should have one cl to fix them all.

http://codereview.chromium.org/8601009/diff/2001/functional/prefs.py#newcode38
functional/prefs.py:38: restore = driver.find_element_by_xpath(
On 2011/11/22 20:42:46, kkania wrote:
> I think a good convention to start is appending '_elem' on to the end for all
> WebElements. change to restore_elem

Done.

[commit-bot: I haz the power, 2011-11-22 22:37:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vivianz@chromium.org/8601009/7001

[commit-bot: I haz the power, 2011-11-23 02:38:59]

Change committed as 111295