Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 8601003: Small tweak to about:profiler -- make the labels for checkboxes clickable (so you have a bigger t... (Closed)

Created:
9 years, 1 month ago by eroman
Modified:
9 years, 1 month ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Small tweak to about:profiler -- make the labels for checkboxes clickable (so you have a bigger target to click on than just the tiny checkbox). Apparently if you surround an <input type=checkbox> within a <label> tag, the text will activate the checkbox. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110995

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
M chrome/browser/resources/profiler.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/profiler.js View 3 chunks +22 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
eroman
9 years, 1 month ago (2011-11-18 03:40:14 UTC) #1
jar (doing other things)
lgtm
9 years, 1 month ago (2011-11-18 22:48:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/8601003/1
9 years, 1 month ago (2011-11-19 01:37:23 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-19 03:10:05 UTC) #4
Try job failure for 8601003-1 (retry) (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Powered by Google App Engine
This is Rietveld 408576698