Issue 8600007: base::Bind: Convert chrome/service/cloud_print.

Issue 8600007: base::Bind: Convert chrome/service/cloud_print. (Closed)

Created:
9 years, 1 month ago by James Hawkins

Modified:
9 years, 1 month ago

Reviewers:
csilv

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

base::Bind: Convert chrome/service/cloud_print. BUG=none TEST=none R=csilv@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110827

Patch Set 4 : Rebase and review fixes. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+131 lines, -116 lines)			Patch
M	chrome/service/cloud_print/cloud_print_auth.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_connector.cc	View	1 2 3	4 chunks	+10 lines, -10 lines	0 comments	Download
M	chrome/service/cloud_print/print_system.h	View	1	3 chunks	+6 lines, -7 lines	0 comments	Download
M	chrome/service/cloud_print/print_system_cups.cc	View	1 2	15 chunks	+34 lines, -29 lines	0 comments	Download
M	chrome/service/cloud_print/print_system_win.cc	View	1 2	16 chunks	+70 lines, -61 lines	0 comments	Download
M	chrome/service/cloud_print/printer_job_handler.cc	View	1 2 3	2 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/service/service_utility_process_host.h	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

csilv

lgtm http://codereview.chromium.org/8600007/diff/4001/chrome/service/cloud_print/cloud_print_connector.cc File chrome/service/cloud_print/cloud_print_connector.cc (right): http://codereview.chromium.org/8600007/diff/4001/chrome/service/cloud_print/cloud_print_connector.cc#newcode7 chrome/service/cloud_print/cloud_print_connector.cc:7: #include "base/bind.h" add bind/bind_helpers.h http://codereview.chromium.org/8600007/diff/4001/chrome/service/cloud_print/printer_job_handler.cc File chrome/service/cloud_print/printer_job_handler.cc (right): ...

9 years, 1 month ago (2011-11-19 01:33:57 UTC) #2

James Hawkins

9 years, 1 month ago (2011-11-19 01:49:35 UTC) #3

http://codereview.chromium.org/8600007/diff/4001/chrome/service/cloud_print/c...
File chrome/service/cloud_print/cloud_print_connector.cc (right):

http://codereview.chromium.org/8600007/diff/4001/chrome/service/cloud_print/c...
chrome/service/cloud_print/cloud_print_connector.cc:7: #include "base/bind.h"
On 2011/11/19 01:33:57, csilv wrote:
> add bind/bind_helpers.h

Done.

http://codereview.chromium.org/8600007/diff/4001/chrome/service/cloud_print/p...
File chrome/service/cloud_print/printer_job_handler.cc (right):

http://codereview.chromium.org/8600007/diff/4001/chrome/service/cloud_print/p...
chrome/service/cloud_print/printer_job_handler.cc:7: #include "base/bind.h"
On 2011/11/19 01:33:57, csilv wrote:
> add bind/bind_helpers.h

Done.

Expand Messages | Collapse Messages