Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: chrome/browser/prerender/prerender_histograms.cc

Issue 8600004: Adding a fourth omnibox prerender experiment. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_histograms.cc
diff --git a/chrome/browser/prerender/prerender_histograms.cc b/chrome/browser/prerender/prerender_histograms.cc
index dfbb5839813c379c16e9ade07d3d9d7664f76833..bbd86e93d2fdf5c337d663ee10ffc4d29c240895 100644
--- a/chrome/browser/prerender/prerender_histograms.cc
+++ b/chrome/browser/prerender/prerender_histograms.cc
@@ -42,6 +42,10 @@ std::string GetHistogramName(Origin origin, uint8 experiment_id,
if (experiment_id != kNoExperiment)
return ComposeHistogramName("wash", name);
return ComposeHistogramName("omnibox_exact", name);
+ case ORIGIN_OMNIBOX_EXACT_FULL:
+ if (experiment_id != kNoExperiment)
cbentzel 2011/11/18 21:24:06 Feels like the experiment_id != kNoExperiment shou
dominich 2011/11/18 23:05:51 Done.
+ return ComposeHistogramName("wash", name);
+ return ComposeHistogramName("omnibox_exact_full", name);
case ORIGIN_LINK_REL_PRERENDER:
if (experiment_id != kNoExperiment)
return ComposeHistogramName("wash", name);
@@ -97,11 +101,10 @@ std::string GetHistogramName(Origin origin, uint8 experiment_id,
experiment != recording_experiment)) { \
} else if (origin == ORIGIN_LINK_REL_PRERENDER) { \
HISTOGRAM; \
- } else if (origin == ORIGIN_OMNIBOX_ORIGINAL) { \
- HISTOGRAM; \
- } else if (origin == ORIGIN_OMNIBOX_CONSERVATIVE) { \
- HISTOGRAM; \
- } else if (origin == ORIGIN_OMNIBOX_EXACT) { \
+ } else if (origin == ORIGIN_OMNIBOX_ORIGINAL || \
+ origin == ORIGIN_OMNIBOX_CONSERVATIVE || \
+ origin == ORIGIN_OMNIBOX_EXACT || \
+ origin == ORIGIN_OMNIBOX_EXACT_FULL) { \
HISTOGRAM; \
} else if (experiment != kNoExperiment) { \
HISTOGRAM; \

Powered by Google App Engine
This is Rietveld 408576698